github.com/argoproj/argo-cd/v2
Affected
- introduced
0, fixed2.8.13(semver)
Fixed versions
2.8.13
Fix
- Fixed version
2.8.13go get github.com/argoproj/argo-cd/[email protected]
Advisory
Also known as: BIT-argo-cd-2024-21652, BIT-argo-cd-2024-21662, CVE-2024-21652, CVE-2024-21662, GHSA-x32m-mvfj-52xv, GO-2024-2652
Bypassing Rate Limit and Brute Force Protection Using Cache Overflow
Summary
An attacker can effectively bypass the rate limit and brute force protections by exploiting the application's weak cache-based mechanism. This loophole in security can be combined with other vulnerabilities to attack the default admin account. This flaw undermines a previously patched CVE intended to protect against brute-force attacks.
Details
The application's brute force protection relies on a cache mechanism that tracks login attempts for each user. This cache is limited to a defaultMaxCacheSize of 1000 entries. An attacker can overflow this cache by bombarding it with login attempts for different users, thereby pushing out the admin account's failed attempts and effectively resetting the rate limit for that account.
The brute force protection mechanism's code:
if failed && len(failures) >= getMaximumCacheSize() {
log.Warnf("Session cache size exceeds %d entries, removing random entry",
getMaximumCacheSize())
idx := rand.Intn(len(failures) - 1)
var rmUser string
i := 0
for key := range failures {
if i == idx {
rmUser = key
delete(failures, key)
break
}
i++ }
log.Infof("Deleted entry for user %s from cache", rmUser)
}
PoC
In just 15 minutes, the PoC was able to perform 230 brute force attempts on the admin account. This rate allows for approximately 1000 requests per hour, effectively rendering the older CVE rate limit patches useless.
Impact
This is a severe vulnerability that enables attackers to perform brute force attacks at an accelerated rate, especially targeting the default admin account.
Medium Basis: The source's own band: MODERATE
0, fixed 2.8.13 (semver)2.8.13
2.8.13go get github.com/argoproj/argo-cd/[email protected]2.9.0, fixed 2.9.9 (semver)2.9.9
2.9.9go get github.com/argoproj/argo-cd/[email protected]2.10.0, fixed 2.10.4 (semver)2.10.4
2.10.4go get github.com/argoproj/argo-cd/[email protected]Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.
Check your own computer: guard packages check
Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0