Advisory

GHSA-3227-r97m-8j95

Also known as: None

Summary

Relative Path Traversal in afire serve_static

Details

Impact
This vulnerability effects the built-in afire serve_static extension allowing paths containing //.... to bypass the previous path sanitation and request files in higher directories that should not be accessible.

Patches
The issue has been fixed in afire 1.1.0.
If you can, just update to the newest version of afire.

Workarounds
If you can't update afire you can simply disallow paths containing /.. with the following middleware.
Make sure this is the last middleware added to the server so it runs first, stopping the bad requests.

use afire::prelude::*;

struct PathTraversalFix;

impl Middleware for PathTraversalFix {
    fn pre(&self, req: Request) -> MiddleRequest {
        if req.path.replace("\\", "/").contains("/..") {
            return MiddleRequest::Send(
                Response::new()
                    .status(400)
                    .text("Paths containing `..` are not allowed"),
            );
        }

        MiddleRequest::Continue
    }
}
let mut server = Server::new(host, port);
PathTraversalFix.attach(&mut server);

References
You can read about the new changes to afire in 1.1.0 here

For more information
If you have any questions or comments about this advisory you can email me or message me on discord.
[https://connorcode.com/contact]

Severity

High Basis: The source's own band: HIGH

Dates

Published
2022-04-22 20:16 UTC
Modified
2022-04-22 20:16 UTC

Affected packages and fixes

afire

crates.io · All systems

Affected

  • introduced 0.2.1, fixed 1.1.0 (semver)

Fixed versions

1.1.0

Fix

  • Fixed version 1.1.0
    cargo update -p afire --precise 1.1.0

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences