@finos/git-proxy
Affected
- introduced
0, fixed1.19.2(semver)
Fixed versions
1.19.2
Fix
- Fixed version
1.19.2npm install @finos/[email protected]
Advisory
Also known as: CVE-2025-54585
GitProxy New Branch Approval Exploit
Summary
An attacker can exploit the way GitProxy handles new branch creation to bypass the approval of prior commits on the parent branch.
Because it can greatly affect system integrity, we classify this as a High impact vulnerability.
Details
GitProxy checks for the 0000000000000000000000000000000000000000 hash to detect new branches. This is used to process the commit accordingly in both getDiff.ts and parsePush.ts. However, the logic can be exploited as follows:
a (could be main)b from that commitb, then approve it/get it approveda, and attempt to push this commit to the proxyThe unapproved commit from a will be pushed to the remote.
PoC
To reproduce this vulnerability:
git checkout -b a origin/main
echo "DEBUG=true" > config.env
git add config.env
git commit -m "Sensitive debug config"
git push proxy a
a, create a new branch b based on it:git checkout -b b
echo "feature x implemented" > feature.txt
git add feature.txt
git commit -m "Feature implementation"
git push proxy b
b.a:git checkout a
git push proxy a
Prior to 1.19.2, this results in unapproved commits from a getting pushed without any policy checks or explicit approval.
From 1.19.2 onwards, this flow will allow pushing all commits to branch b (and explicit approval will be asked for the changes on b only). However, commits on branch a now require approval on push. If merging branch b into a, this also requires explicit approval of the (previously unapproved) commits originating from a to prevent loopholes.
Impact
The vulnerability impacts all users or organizations relying on GitProxy to enforce policy and prevent unapproved changes. It requires no elevated privileges beyond regular push access, and no extra user interaction. It does however, require a GitProxy administrator or designated user (canUserApproveRejectPush) to approve pushes to the child branch.
High Basis: The source's own band: HIGH
0, fixed 1.19.2 (semver)1.19.2
1.19.2npm install @finos/[email protected]Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.
Check your own computer: guard packages check
Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0