github.com/huandu/facebook/v2
Affected
- introduced
0, fixed2.7.2(semver)
Fixed versions
2.7.2
Fix
- Fixed version
2.7.2go get github.com/huandu/facebook/[email protected]
Advisory
Also known as: CVE-2024-35232, GO-2024-2882
github.com/huandu/facebook may expose access_token in error message.
Summary
access_token can be exposed in error message on fail in HTTP request.
Details
Using this module, when HTTP request fails, error message can contain access_token. This can be happen when:
?access_token=....facebook: cannot reach facebook server).In such situation, error message is constucted like following.
https://github.com/huandu/facebook/blob/1591be276561bbdb019c0279f1d33cb18a650e1b/session.go#L558-L567
Original error message contained in it comes from net/http module. And it can contain full URL, that can contain query parameter access_token:
https://cs.opensource.google/go/go/+/refs/tags/go1.22.3:src/net/http/client.go;l=629-633
https://cs.opensource.google/go/go/+/refs/tags/go1.22.3:src/net/url/url.go;l=30
It should be very common that applications log error message when they encounter errors. As a result, access_token can be stored into log server and some other infrastructures. Of course other careless error handling in client code that causing other security problems can exist.
I'm not very sure that whether we can consider that github.com/huandu/facebook is vulnerable. Anyway, I think current error message, that can expose access_token, is not desirble.
PoC
Request me this section if you need complete instruction.
Impact
Client applications with following conditions can be affected.
Low Basis: The source's own band: LOW
0, fixed 2.7.2 (semver)2.7.2
2.7.2go get github.com/huandu/facebook/[email protected]Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.
Check your own computer: guard packages check
Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0