Advisory

GHSA-3v43-877x-qgmq

Also known as: CVE-2019-10010

Summary

Moderate severity vulnerability that affects league/commonmark

Details

CVE-2019-10010

Impact

In league/commonmark 0.18.2 and below, malicious users can insert double-encoded HTML entities into their Markdown like this:

[XSS](javascript:alert%28'XSS'%29)

This library would (correctly) unescape the & entity to & during the parsing step. However, the renderer step would fail to properly re-escape the resulting `:` string, thus producing the following malicious HTML output:

<p><a href="javascript&colon;alert('XSS')">XSS</a></p>

Browsers would interpret &colon; as a : character and allow the JS to be executed when the link is clicked.

This vulnerability was present in the upstream library this project was forked from and therefore exists in all prior versions of league/commonmark.

Solution

The new 0.18.3 release mirrors the fix made upstream - we no longer attempt to preserve entities when rendering HTML attributes like href, src, title, etc.

The $preserveEntities parameter of Xml::escape() is therefore no longer used internally, so it has been deprecated and marked for removal in the next major release (0.19.0).

Credits

  • Mohit Fawaz for identifying the issue
  • Sebastiaan Knijnenburg and Ross Tuck for responsibly disclosing/relaying the issue
  • John MacFarlane for investigating it and implementing the upstream fix we mirrored here

References

  • https://nvd.nist.gov/vuln/detail/CVE-2019-10010
  • https://github.com/thephpleague/commonmark/releases/tag/0.18.3
  • https://github.com/thephpleague/commonmark/issues/353
  • https://github.com/FriendsOfPHP/security-advisories/blob/master/league/commonmark/CVE-2019-10010.yaml

Severity

Medium Basis: The source's own band: MODERATE

Dates

Published
2019-09-17 22:47 UTC
Modified
2024-02-16 08:15 UTC

Affected packages and fixes

league/commonmark

Packagist · All systems

Affected

  • introduced 0, fixed 0.18.3 (ecosystem)

Fixed versions

0.18.3

Fix

The export has no generic command for this ecosystem.

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences