Advisory

GHSA-45cj-f97f-ggwv

Also known as: CVE-2022-39335, PYSEC-2023-65

Summary

Synapse does not apply enough checks to servers requesting auth events of events in a room

Details

Impact
Synapse is an open-source Matrix homeserver written and maintained by the Matrix.org Foundation. The Matrix Federation API allows remote homeservers to request the *authorisation events* of events in a room. This is necessary so that a homeserver receiving some events can validate that those events are legitimate and permitted in their room.
However, in versions of Synapse up to and including 1.68.0, a Synapse homeserver answering a query for authorisation events does not sufficiently check that the requesting server should be able to access them.

Authorisation events include power level events (the list of user IDs and their power levels at the time) and relevant membership events (including the display name of the sender of that event), as well as events like m.room.create, m.room.third_party_invite and m.room.join_rules. Non-authorisation events are unaffected, so it isn't possible to e.g. extract message contents this way.

This issue is only exploitable when a malicious actor knows the ID of a target room and the ID of an event from that room. In most cases, this makes exploitation infeasible. This issue is of negligible consequence for public rooms given that any server can easily join the room in order to be allowed to view authorisation events. Further, deployments in a closed federation where all homeservers are trustworthy are not affected.

Patches

The issue was patched in Synapse 1.69.0. Homeserver administrators are advised to upgrade.

Workarounds

Synapse can be configured with a list of servers that it is allowed to federate with [federation_domain_whitelist]. If this list is in use and all the servers on the list are trusted not to exploit this issue, then this issue is of no consequence.

This workaround is not practical for homeservers participating in open federation as interaction with any server not on the list would have to happen indirectly through servers that are, leading to inconsistent delays in message delivery.

[federation_domain_whitelist]: https://matrix-org.github.io/synapse/v1.68/usage/configuration/config_documentation.html#federation_domain_whitelist

References

Fixed in https://github.com/matrix-org/synapse/pull/13823.

For more information

If you have any questions or comments about this advisory, e-mail us at [email protected].

Severity

High Basis: The source's own band: HIGH

Dates

Published
2023-05-24 17:20 UTC
Modified
2024-09-24 20:33 UTC

Affected packages and fixes

matrix-synapse

PyPI · All systems

Affected

  • introduced 0, fixed 1.69.0 (ecosystem)

Fixed versions

1.69.0

Fix

  • Fixed version 1.69.0
    pip install --upgrade matrix-synapse==1.69.0

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences