Advisory

GHSA-4jg2-84c2-pj95

Also known as: CVE-2023-23619

Summary

Improper Control of Generation of Code ('Code Injection') in @asyncapi/modelina

Details

Impact
Anyone who is using the default presets and/or does not handle the functionality themself.

Patches
It is impossible to fully guard against this, because users have access to the original raw information. However, as of version 1, if you only access the constrained models, you will not encounter this issue.

Further similar situations are NOT seen as a security issue, but intended behavior.

Workarounds
Fully custom presets that change the entire rendering process which can then escape the user input.

For more information
Even though that I changed all the presets here, the vulnerability is still present throughout. I am using a JSON Schema here for simplicity.

const jsonSchemaDoc = {
  $id: 'CustomClass',
  type: 'object',
  properties: {
      'property: any; \n constructor(){console.log("injected")} \n private _temp': { type: 'string' },
  }
};
generator = new TypeScriptGenerator(
  { 
    presets: [
      {
        class: {
            property({ propertyName, content }) {
              return `private ${propertyName}: any;`;
            },
            ctor() {
              return '';
            },
            getter() {
              return '';
            },
            setter() {
              return '';
            }
        }
      }
    ]
  }
);
const inputModel = await generator.process(jsonSchemaDoc);

This would render

export class CustomClass {
  private property: any; 
   constructor(){console.log("injected")} 
   private _temp: any;
  private additionalProperties: any;
}

Severity

Critical Basis: The source's own band: CRITICAL

Dates

Published
2021-09-21 18:41 UTC
Modified
2026-09-10 03:49 UTC

Affected packages and fixes

@asyncapi/modelina

npm · All systems

Affected

  • introduced 0, fixed 1.0.0 (semver)

Fixed versions

1.0.0

Fix

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences