vyper
Affected
- introduced
0, fixed0.3.4(ecosystem)
Fixed versions
0.3.4
Fix
- Fixed version
0.3.4pip install --upgrade vyper==0.3.4
Advisory
Also known as: CVE-2022-29255, PYSEC-2022-43053
Multiple evaluation of contract address in call in vyper
Impact
when a calling an external contract with no return value, the contract address could be evaluated twice. this is usually only an efficiency problem, but if evaluation of the contract address has side effects, it could result in double evaluation of the side effects.
in the following example, Foo(msg.sender).bar() is the contract address for the following call (to .foo()), and could get evaluated twice
interface Foo:
def foo(): nonpayable
def bar() -> address: nonpayable
@external
def do_stuff():
Foo(Foo(msg.sender).bar()).foo()
Patches
6b4d8ff185de071252feaa1c319712b2d6577f8d
Workarounds
assign contract addresses to variables. the above example would change to
@external
def do_stuff():
t: Foo = Foo(msg.sender).bar()
t.foo()
References
For more information
High Basis: The source's own band: HIGH
0, fixed 0.3.4 (ecosystem)0.3.4
0.3.4pip install --upgrade vyper==0.3.4Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.
Check your own computer: guard packages check
Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0