Advisory

GHSA-5824-cm3x-3c38

Also known as: CVE-2023-39363, PYSEC-2023-142

Summary

Vyper has incorrectly allocated named re-entrancy locks

Details

Impact

In versions 0.2.15, 0.2.16 and 0.3.0, named re-entrancy locks are allocated incorrectly. Each function using a named re-entrancy lock gets a unique lock regardless of the key, allowing cross-function re-entrancy in contracts compiled with the susceptible versions. A specific set of conditions is required to result in misbehavior of affected contracts, specifically:

  • A .vy contract compiled with either of the following vyper versions: 0.2.15, 0.2.16, 0.3.0
  • A primary function that utilizes the @nonreentrant decorator with a specific key and does not strictly follow the check-effects-interaction pattern (i.e. contains an external call to an untrusted party before storage updates)
  • A secondary function that utilizes the same key and would be affected by the improper state caused by the primary function

Patches
https://github.com/vyperlang/vyper/pull/2439, https://github.com/vyperlang/vyper/pull/2514

Workarounds
Upgrade to 0.3.1 or higher

References
Technical post-mortem report: https://hackmd.io/@vyperlang/HJUgNMhs2

Severity

Critical Basis: The source's own band: CRITICAL

Dates

Published
2023-08-09 14:27 UTC
Modified
2026-09-10 03:49 UTC

Affected packages and fixes

vyper

PyPI · All systems

Affected

  • introduced 0.2.15, fixed 0.3.1 (ecosystem)

Fixed versions

0.3.1

Fix

  • Fixed version 0.3.1
    pip install --upgrade vyper==0.3.1

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences