Advisory

GHSA-5873-6fwq-463f

Also known as: CVE-2023-46135

Summary

stellar-strkey vulnerable to panic in SignedPayload::from_payload

Details

Impact
Panic vulnerability when a specially crafted payload is used.
This is because of the following calculation:

inner_payload_len + (4 - inner_payload_len % 4) % 4

If inner_payload_len is 0xffffffff, (4 - inner_payload_len % 4) % 4 = 1 so

inner_payload_len + (4 - inner_payload_len % 4) % 4 = u32::MAX + 1

which overflow.

Patches
Check that inner_payload_len is not above 64 which should never be the case.
Patched in version 0.0.8

Workarounds
Sanitize input payload before it is passed to the vulnerable function so that bytes in payload[32..32+4] and parsed as a u32 is not above 64.

References
GitHub issue #58

Severity

Medium Basis: The source's own band: MODERATE

Dates

Published
2023-10-25 14:09 UTC
Modified
2026-09-10 03:49 UTC

Affected packages and fixes

stellar-strkey

crates.io · All systems

Affected

  • introduced 0, fixed 0.0.8 (semver)

Fixed versions

0.0.8

Fix

  • Fixed version 0.0.8
    cargo update -p stellar-strkey --precise 0.0.8

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences