grumpydictator/firefly-iii
Affected
- introduced
6.4.23, fixed6.5.1(ecosystem)
Fixed versions
6.5.1
Fix
The export has no generic command for this ecosystem.
Advisory
Also known as: None
Firefly III user API endpoints expose all users' information to any authenticated user (IDOR)
Summary
The User management API endpoints (GET /api/v1/users and GET /api/v1/users/{id}) are accessible to any authenticated user without admin/owner role verification, exposing all users' email addresses, roles, and account status.
Affected Endpoints
Root Cause (1-of-N Inconsistency)
Other methods in the same controller properly check for the 'owner' role:
store() — UserStoreRequest::authorize() checks auth()->user()->hasRole('owner') ✓destroy() — Explicitly checks $this->repository->hasRole($admin, 'owner') ✓But index() and show() have no role check at all. The route group at routes/api.php:734-747 has no admin middleware, only the global auth:api middleware.
Exposed Data
The UserTransformer (line 40-54) returns:
email — user's email addressrole — user's role (owner/demo)blocked — account blocked statusblocked_code — block reasoncreated_at / updated_at — timestampsImpact
Any authenticated user can:
Exploitation
# List all users
curl -H "Authorization: Bearer <any_user_token>" https://instance/api/v1/users
# View specific user details
curl -H "Authorization: Bearer <any_user_token>" https://instance/api/v1/users/1
Suggested Fix
Add owner role checks to index() and show(), or restrict the route group with admin middleware:
// Option 1: Add check in controller methods
public function show(User $user): JsonResponse
{
if (!$this->repository->hasRole(auth()->user(), 'owner') && auth()->user()->id !== $user->id) {
throw new FireflyException('200025: No access to function.');
}
// ...
}
// Option 2: Add middleware to route group
Route::group(['middleware' => ['admin'], ...], ...)Medium Basis: The source's own band: MODERATE
6.4.23, fixed 6.5.1 (ecosystem)6.5.1
The export has no generic command for this ecosystem.
Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.
Check your own computer: guard packages check
Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0