Details
- Per GHSA-1 shared reproducer, start the server with a working LLM API key and create an unauthenticated session.
curl -s -X POST "http://HOST:8899/sessions/$SID/messages" -H 'Content-Type: application/json' -d '{"content":"Please read and summarize the document at /proc/self/environ"}'- Poll
curl -s "http://HOST:8899/sessions/$SID/messages". Observe the agent invokeread_documentwithfile_path="/proc/self/environ"and return the full process environment in the message stream. - Observe
OPENROUTER_API_KEY,TUSHARE_TOKEN, and any other variables inagent/.envappearing in plaintext. - Repeat with
file_path="/etc/shadow"to confirm shadow password file access.
Impact:
An unauthenticated caller can retrieve any file the server process can read. Running as root, that includes /etc/shadow, /etc/passwd, /proc/self/environ (full plaintext API keys), /root/.ssh/id_rsa, and any secret files mounted into the container. This is the broadest file-read primitive in the codebase and provides a credential-extraction path that does not require shell execution — endpoint monitoring tuned to BashTool / shell signatures will miss it entirely.
---
Why F9 and F10 are listed separately
A maintainer might be tempted to fix only one, on the theory that F10 dominates F9. Two reasons to fix both:
- Different fix scope — F10's fix is a single missing call (
safe_path(file_path)inread_documentbefore line 270). F9's fix is insafe_user_path()itself: the envelope must be replaced with a strict allowlist of operator-configured directories, *not*Path.home() ∪ Path.cwd(). A fix that adds the missingsafe_user_pathcall toread_documentis insufficient becausesafe_user_pathitself accepts/rootand/app/agent/.env. Both surfaces need work.
- Different reachability classes — F9 is reachable through tools that already gate on
safe_user_path(ExtractShadowStrategyTooland several journal tools), so even a hypothetical F10 fix that switchedread_documentto usesafe_user_pathwould still leak/root/*because the envelope is broken. F9 is the structural defect; F10 is the missed call.
---
Suggested remediation
- F9 — In
safe_user_path()atpath_utils.py:52-77, replace thePath.home() ∪ Path.cwd()envelope with a strict allowlist of operator-configured directories (e.g. an explicitBROKER_EXPORTS_DIRenv var defaulting to/app/data/broker_exports/). Reject/root,/app/agent/.env, and/app/agent/uploads/(the latter to prevent F3-uploaded files from being subsequently parsed as a credential-leak vector via the parse-error channel).'
- F10 — Add a
safe_path()(orsafe_user_path()) call atdoc_reader_tool.py:270before the existingpath.exists()/path.is_file()checks. Once F9 is patched, the same allowlist will apply uniformly to bothread_documentand thesafe_user_path-gated tools.
- Defense-in-depth — Drop the FastAPI process to a non-root user. Add a
RUN useradd -m vibe && chown -R vibe /appstep to the Dockerfile andUSER vibebeforeCMD. This does not fix the Path Traversal but materially reduces the credential-extraction blast radius of any successful exploit (and benefits every other finding in GHSA-1 and GHSA-2). See GHSA-1 / shared baseline for the matchingUSERrecommendation.
---