orml-rewards
Affected
- introduced
0, fixed1.2.1(semver)
Fixed versions
1.2.1
Fix
- Fixed version
1.2.1cargo update -p orml-rewards --precise 1.2.1
Advisory
Also known as: None
Uncaught Panic in ORML Rewards Pallet
Summary
A vulnerability in the add_share function of the Rewards pallet (part of the ORML repository) can lead to an uncaught Rust panic when handling user-provided input exceeding the u128 range.
Affected Components
rewards/src/lib.rs)add_share accepting unvalidated large u128 inputsTechnical Details
add_share performs arithmetic on user-supplied values (add_amount) of type T::Share (mapped to u128 in Acala).add_amount is large enough (e.g., i128::MAX), the intermediate result may overflow and panic on the cast to u128.Impact
A malicious user submitting a specially crafted extrinsic can cause a panic in the runtime:
Likelihood
This issue is exploitable in production if there exists at least one rewards pool where reward tokens exceed twice the collateral tokens, allowing sufficiently large multiplication to exceed u128 bounds.
Remediation
Backport
The patch have been backported to following release branches:
A 1.0.1 patch release is made with this fix.
High Basis: The source's own band: HIGH
0, fixed 1.2.1 (semver)1.2.1
1.2.1cargo update -p orml-rewards --precise 1.2.1Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.
Check your own computer: guard packages check
Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0