Advisory

GHSA-68vr-8f46-vc9f

Also known as: CVE-2022-21696, PYSEC-2022-47

Summary

Username spoofing in OnionShare

Details

Between September 26, 2021 and October 8, 2021, Radically Open Security conducted a penetration test of OnionShare 2.4, funded by the Open Technology Fund's Red Team lab. This is an issue from that penetration test.

  • Vulnerability ID: OTF-005
  • Vulnerability type: Improper Input Sanitization
  • Threat level: Low

Description:

It is possible to change the username to that of another chat participant with an additional space character at the end of the name string.

Technical description:

Assumed users in Chat:

  • Alice
  • Bob
  • Mallory
  1. Mallory renames to Alice .
  2. Mallory sends message as Alice .
  3. Alice and Bob receive a message from Mallory disguised as Alice , which is hard to distinguish from the Alice

in the web interface.

otf-005-a
otf-005-b

Other (invisible) whitespace characters were found to be working as well.

Impact:

An adversary with access to the chat environment can use the rename feature to impersonate other participants by adding whitespace characters at the end of the username.

Recommendation:

  • Remove non-visible characters from the username

Severity

Medium Basis: The source's own band: MODERATE

Dates

Published
2022-01-21 23:20 UTC
Modified
2024-10-08 12:47 UTC

Affected packages and fixes

onionshare-cli

PyPI · All systems

Affected

  • introduced 2.3, fixed 2.5 (ecosystem)

Fixed versions

2.5

Fix

  • Fixed version 2.5
    pip install --upgrade onionshare-cli==2.5

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences