@fedify/fedify
Affected
- introduced
0, fixed1.3.20(semver)
Fixed versions
1.3.20
Fix
- Fixed version
1.3.20npm install @fedify/[email protected]
Advisory
Also known as: CVE-2025-54888
@fedify/fedify has Improper Authentication and Incorrect Authorization
Summary
An authentication bypass vulnerability allows any unauthenticated attacker to impersonate any ActivityPub actor by sending forged activities signed with their own keys. Activities are processed before verifying the signing key belongs to the claimed actor, enabling complete actor impersonation across all Fedify instances
Details
The vulnerability exists in handleInboxInternal function in fedify/federation/handler.ts. The critical flaw is in the order of operations:
// fedify/federation/handler.ts:1712-1750
const routeResult = await routeActivity({ // ← Activity processed here
context: ctx,
json,
activity,
recipient,
inboxListeners,
inboxContextFactory,
inboxErrorHandler,
kv,
kvPrefixes,
queue,
span,
tracerProvider,
});
if (
httpSigKey != null && !await doesActorOwnKey(activity, httpSigKey, ctx) // ← Auth check too late
) {
// Returns 401, but activity already processed
return new Response("The signer and the actor do not match.", {
status: 401,
headers: { "Content-Type": "text/plain; charset=utf-8" },
});
}
By the time the 401 response is returned, the malicious activity has already been processed or queued.
PoC
const maliciousActivity = {
"@context": "https://www.w3.org/ns/activitystreams",
"type": "Create",
"actor": "https://victim.example.com/users/alice", // Impersonating victim
"object": {
"type": "Note",
"content": "This is a forged message!"
}
}
// Sign with attacker's key: https://attacker.com/users/eve#main-key
const signedRequest = await signRequest(request, attackerPrivateKey, attackerKeyId);
Impact
Type: Authentication Bypass / Actor Impersonation
Who is impacted: All Fedify instances and their users
Consequences: Allows complete impersonation of any ActivityPub actor, enabling:
The vulnerability affects all Fedify instances but does not propagate to other ActivityPub implementations (Mastodon, etc.) which properly validate before processing.
High Basis: The source's own band: HIGH
0, fixed 1.3.20 (semver)1.3.20
1.3.20npm install @fedify/[email protected]1.4.0-dev.585, fixed 1.4.13 (semver)1.4.13
1.4.13npm install @fedify/[email protected]1.5.0-dev.636, fixed 1.5.5 (semver)1.5.5
1.5.5npm install @fedify/[email protected]1.6.0-dev.754, fixed 1.6.8 (semver)1.6.8
1.6.8npm install @fedify/[email protected]1.7.0-pr.251.885, fixed 1.7.9 (semver)1.7.9
1.7.9npm install @fedify/[email protected]1.8.0-dev.909, fixed 1.8.5 (semver)1.8.5
1.8.5npm install @fedify/[email protected]Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.
Check your own computer: guard packages check
Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0