Advisory

GHSA-6qmf-fj6m-686c

Also known as: CVE-2021-32618, PYSEC-2021-123

Summary

Open Redirect in Flask-Security-Too

Details

Impact
Flask-Security allows redirects after many successful views (e.g. /login) by honoring the ?next query param. There is code in FS to validate that the url specified in the next parameter is either relative OR has the same netloc (network location) as the requesting URL.

This check utilizes Pythons urlsplit library. However many browsers are very lenient on the kind of URL they accept and 'fill in the blanks' when presented with a possibly incomplete URL. As a concrete example - setting http://login?next=\\\github.com
will pass FS's relative URL check however many browsers will gladly convert this to http://github.com. Thus an attacker could send such a link to an unwitting user, using a legitimate site and have it redirect to whatever site they want.

This is considered a low severity due to the fact that if Werkzeug by default ALWAYS ensures that the Location header is absolute - thus making this attack vector mute. It is possible for application writers to modify this default behavior by setting the 'autocorrect_location_header=False` which would then open up their application to this attack.

Patches
No patches as this time

Workarounds
If using Werkzeug, make sure to use the default Location header setting. If you can't - then [email protected]_request and write your own validation of the Location header if it is set.

References
No.

For more information
If you have any questions or comments about this advisory follow: https://github.com/Flask-Middleware/flask-security/issues/486

Thanks to Claroty (2021-0141) and @snoopysecurity for providing details and proof of concept.

Severity

Low Basis: The source's own band: LOW

Dates

Published
2021-05-17 20:51 UTC
Modified
2024-09-20 21:25 UTC

Affected packages and fixes

flask-security-too

PyPI · All systems

Affected

  • introduced 0, fixed 4.1.0 (ecosystem)

Fixed versions

4.1.0

Fix

  • Fixed version 4.1.0
    pip install --upgrade flask-security-too==4.1.0

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences