Advisory

GHSA-6xv5-86q9-7xr8

Also known as: GO-2023-2048

Summary

SecureJoin: on windows, paths outside of the rootfs could be inadvertently produced

Details

Impact
For Windows users of github.com/cyphar/filepath-securejoin, until v0.2.4 it was possible for certain rootfs and path combinations (in particular, where a malicious Unix-style /-separated unsafe path was used with a Windows-style rootfs path) to result in generated paths that were outside of the provided rootfs.

It is unclear to what extent this has a practical impact on real users, but given the possible severity of the issue we have released an emergency patch release that resolves this issue.

Thanks to @pjbgf for discovering, debugging, and fixing this issue (as well as writing some tests for it).

Patches
c121231e1276e11049547bee5ce68d5a2cfe2d9b is the patch fixing this issue. v0.2.4 contains the fix.

Workarounds
Users could use filepath.FromSlash() on all unsafe paths before passing them to filepath-securejoin.

References
See #9.

Severity

Medium Basis: The source's own band: MODERATE

Dates

Published
2023-09-07 12:58 UTC
Modified
2026-09-10 03:49 UTC

Affected packages and fixes

github.com/cyphar/filepath-securejoin

Go · All systems

Affected

  • introduced 0, fixed 0.2.4 (semver)

Fixed versions

0.2.4

Fix

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences