Advisory

GHSA-7cqp-7cfv-6c3q

Details, part 2 of 2. The advisory

Details

Suggested fix

Encode the stored value at the sink in plugin/Meet/getMeetInfo.json.php:71:

. '</span><br><small class="text-muted">' . htmlspecialchars($value['user_agent'], ENT_QUOTES, 'UTF-8') . '</small></li>';

Defense in depth: sanitize the value on write in Meet_join_log::setUser_agent(), mirroring the setter-layer encoding used by Meet_schedule::setTopic() (xss_esc()), so any other current or future reader of meet_join_log.user_agent is also protected.

Fix PR

A fix is provided on the advisory's private temporary fork: WWBN/AVideo-ghsa-7cqp-7cfv-6c3q#1 (encodes the participant User-Agent at the sink with htmlspecialchars($value['user_agent'], ENT_QUOTES, 'UTF-8')).

Credit

Reported by tonghuaroot.

Sources & licences