github.com/tobychui/zoraxy
Affected
- introduced
2.6.1, fixed3.1.3(semver)
Fixed versions
3.1.3
Fix
- Fixed version
3.1.3go get github.com/tobychui/[email protected]
Advisory
Also known as: CVE-2024-52010, GO-2024-3267
Zoraxy has an authenticated command injection in the Web SSH feature
Summary
A command injection vulnerability in the Web SSH feature allows an authenticated attacker to execute arbitrary commands as root on the host.
Details
Zoraxy has a Web SSH terminal feature that allows authenticated users to connect to SSH servers from their browsers.
In `HandleCreateProxySession` the request to create an SSH session is handled. After checking for the presence of required parameters, ensuring that the target is not the loopback interface and that there is actually an SSH service running on the target, CreateNewConnection is called:
https://github.com/tobychui/zoraxy/blob/e79a70b7acfa45c2445aff9d60e4e7525c89fec8/src/mod/sshprox/sshprox.go#L165-L178
In line 178, the gotty binary is executed running sshCommand from the line above. It contains the user-controlled variable connAddr, which includes the hostname of the SSH server and - if provided - the username.
An attacker can exploit the username variable to escape from the bash command and inject arbitrary commands into sshCommand. This is possible, because, unlike hostname and port, the username is not validated or sanitized.
This vulnerability was introduced in https://github.com/tobychui/zoraxy/commit/c07d5f85dfc37bd32819358ed7d4bc32c604e8f0.
If Zoraxy is run without authentication of the management interface (started with-noauth), this vulnerability can be exploited without authentication.
Additionally, if Zoraxy is run in Docker with the Docker socket mounted (as described in https://github.com/tobychui/zoraxy/blob/9cb315ea6739d1cc201b690322d25166b12dc5db/docker/README.md), this vulnerability can be exploited to escape the Zoraxy container and gain access to the Docker host.
PoC
github.com; bash ; as userConnect using SSHbash running on the Zoraxy hostDemo:
https://github.com/user-attachments/assets/5a3d8771-167f-4a79-8665-ed0dfb490181
Impact
This vulnerability allows an authenticated attacker to gain remote code execution with the privileges of the Zoraxy process (root by default). This affects Zoraxy versions 2.6.1 through 3.1.2.
High Basis: The source's own band: HIGH
2.6.1, fixed 3.1.3 (semver)3.1.3
3.1.3go get github.com/tobychui/[email protected]Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.
Check your own computer: guard packages check
Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0