Details
Step 4: Observe the unsafe HTML
The current renderer produced:
inline: font-family: serif" tabindex="0" autofocus onfocus="document.body.dataset.inline='executed';
The serializer then produced an attribute string equivalent to:
id="audit-inline"
data-apos-widget-style-wrapper-for="widget-1"
data-apos-widget-style-classes=""
style="font-family: serif" tabindex="0" autofocus
onfocus="document.body.dataset.inline='executed';"
The attacker-controlled quote terminates the style attribute. tabindex, autofocus, and onfocus become separate live attributes.
Step 5: Confirm execution in a browser
When the generated wrapper was loaded in Chrome 153, autofocus triggered the injected handler automatically. The DOM changed to:
<body data-inline="executed">
<div id="audit-inline" tabindex="0" autofocus="" onfocus="..."></div>
</body>
The safe behavior would be for the quote to appear as " inside the style attribute, with no injected attributes and no change to document.body.dataset.
Impact
- Stored XSS on published pages: JavaScript executes for unauthenticated visitors who load a page containing the affected widget.
- Privilege escalation: If an administrator or another privileged editor views the page or draft, the payload executes with that user's application-origin privileges and can perform authenticated actions available to the victim.
- Persistent content manipulation: The payload is stored with widget content and continues to execute until the style value is removed or the output path is fixed.
- Phishing and data access: The script can alter the rendered page, read non-HttpOnly same-origin data, and issue same-origin requests as the victim.
Recommended Fix
Fix 1: HTML-escape every string-returning attribute value
The string branch of getWidgetAttributes() should encode values for a double-quoted HTML attribute context before concatenation. At minimum, encode &, <, >, ", and ' using a centralized Apostrophe HTML encoder.
Conceptually:
if (options.asObject) {
return Object.fromEntries(attrs);
}
return attrs
.map(([ key, value ]) => {
return `${key}="${escapeHtmlAttribute(String(value))}"`;
})
.join(' ');
The structured asObject branch should remain structured so that its eventual template/DOM renderer can perform context-appropriate encoding.
Fix 2: Validate style values by their destination grammar
Output encoding is the primary fix. As defense in depth:
- Require select/range/color or another constrained type for common CSS properties.
- Parse and validate free-form CSS property values instead of treating them as arbitrary strings.
- For
class: true, accept only individual valid class-name tokens rather than an unrestricted string.