dirac
Affected
- introduced
6, fixed8.0.79(ecosystem)
Fixed versions
8.0.79
Fix
- Fixed version
8.0.79pip install --upgrade dirac==8.0.79
Advisory
Also known as: None
DIRAC: SQL injection and lack of access control in PilotManager service
Details
A number of the functions in PilotManager pass parameters directly through to the database layer, which then does not do any escaping on the parameters. For example setPilotStatus:
https://github.com/DIRACGrid/DIRAC/blob/1738e7c6d2f31d26f1364255d9d2e87b4896c922/src/DIRAC/WorkloadManagementSystem/Service/PilotManagerHandler.py#L343-L349
https://github.com/DIRACGrid/DIRAC/blob/1738e7c6d2f31d26f1364255d9d2e87b4896c922/src/DIRAC/WorkloadManagementSystem/DB/PilotAgentsDB.py#L117
This won't accept multiple statements separated by a semicolon, but a carefully crafted set of parameters containing SQL escapes would likely be able to change or return other database entries.
Further to this, the PilotManager access control is only set to "authenticated"; this allows these functions to be called by any user. This allows any user to manage (e.g. delete, read output of) any pilot pilot job:
https://github.com/DIRACGrid/DIRAC/blob/1738e7c6d2f31d26f1364255d9d2e87b4896c922/src/DIRAC/WorkloadManagementSystem/ConfigTemplate.cfg#L111-L118
This is fixed by changing the SQL statements to use proper parameter substitution and providing a suitable set of access rules for the exported pilot management functions.
Patched versions:
https://pypi.org/project/DIRAC/8.0.79/
https://pypi.org/project/DIRAC/9.0.22/
https://pypi.org/project/DIRAC/9.1.10/
High Basis: The source's own band: HIGH
6, fixed 8.0.79 (ecosystem)8.0.79
8.0.79pip install --upgrade dirac==8.0.798.1.0a1, fixed 9.0.22 (ecosystem)9.0.22
9.0.22pip install --upgrade dirac==9.0.229.1.0, fixed 9.1.10 (ecosystem)9.1.10
9.1.10pip install --upgrade dirac==9.1.10Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.
Check your own computer: guard packages check
Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0