Advisory

GHSA-84c3-j8r2-mcm8

Also known as: None

Summary

@nfid/embed has compromised private key due to @dfinity/auth-client producing insecure session keys

Details

Problem
User sessions in the @nfid/embed SDK with Ed25519 keys are vulnerable due to a compromised private key 535yc-uxytb-gfk7h-tny7p-vjkoe-i4krp-3qmcl-uqfgr-cpgej-yqtjq-rqe. This exposes users to potential loss of funds on ledgers and unauthorized access to canisters they control.

Solution
Using version >1.0.1 of @dfinity/auth-client and @dfinity/identity packages, or @nfid/embed >0.10.1-alpha.6 includes patched versions of the issue.

User sessions will be automatically fixed when they re-authenticate.

Why this happened
The DFINITY auth client library provides a function, Ed25519KeyIdentity.generate, for generating an Ed25519 key pair. This function includes an optional parameter to supply a 32-byte seed value, which will be utilized as the secret key. In cases where no seed value is provided, the library is expected to generate the secret key using secure randomness. However, a recent update of DFINITY libraries has compromised this assurance by employing an insecure seed for key pair generation.

References
AgentJS CVE

Severity

Critical Basis: The source's own band: CRITICAL

Dates

Published
2024-02-26 20:10 UTC
Modified
2024-02-26 20:10 UTC

Affected packages and fixes

@nfid/embed

npm · All systems

Affected

  • introduced 0.10.0, fixed 0.10.1-alpha.6 (semver)

Fixed versions

0.10.1-alpha.6

Fix

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences