Advisory

GHSA-8phr-637g-pxrg

Also known as: CVE-2023-48295

Summary

LibreNMS Cross-site Scripting at Device groups Deletion feature

Details

Summary
XSS attacks occurs when application is not sanitising inputs properly and rendering the code from user input to browser which could allow an attacker to execute malicious javascript code.

PoC

  1. Login
  2. Create a device group in /device-groups
  3. Name it as "><img src=x onerror=alert(1);>
  4. save it
  5. Go to services and create a service template and add that device group into that and save it
  6. After that go back to device groups and delete that device, you will see XSS payload popup in message

<img width="1043" alt="Screenshot 2023-11-08 at 9 15 56 PM" src="https://user-images.githubusercontent.com/31764504/281489434-9beaebd6-b9ce-4098-a8e0-d67b185062b5.png">

Vulnerable code:
https://github.com/librenms/librenms/blob/63eeeb71722237d1461a37bb6da99fda25e02c91/app/Http/Controllers/DeviceGroupController.php#L173C21-L173C21

Line 173 is not sanitizing device name properly
<img width="793" alt="Screenshot 2023-11-08 at 9 26 14 PM" src="https://user-images.githubusercontent.com/31764504/281490570-5ae6e73a-37ce-4683-8bc8-81655abd8d09.png">

Impact
Cross site scripting can lead to cookie stealing attacks

Severity

Medium Basis: The source's own band: MODERATE

Dates

Published
2023-11-17 21:51 UTC
Modified
2024-02-16 08:19 UTC

Affected packages and fixes

librenms/librenms

Packagist · All systems

Affected

  • introduced 0, fixed 23.11.0 (ecosystem)

Fixed versions

23.11.0

Fix

The export has no generic command for this ecosystem.

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences