Details
Recommended Fix
Apply the project's own prescribed CSRF pattern to the handler. Two layers are appropriate:
- Require an authenticated session and reject untrusted-origin requests (same treatment as
userUpdate.json.php). - Restrict the method to
POSTso drive-by<img>and navigationalGETdeliveries cannot reach the sink.
// objects/commentDelete.json.php
<?php
header('Content-Type: application/json');
global $global, $config;
if (!isset($global['systemRootPath'])) {
require_once '../videos/configuration.php';
}
require_once $global['systemRootPath'] . 'objects/comment.php';
// --- added CSRF defense ---
if (!User::isLogged()) {
die(_json_encode((object)['error' => true, 'msg' => __('Is not logged')]));
}
forbidIfIsUntrustedRequest(); // Referer/Origin gate
if ($_SERVER['REQUEST_METHOD'] !== 'POST') { // no $_REQUEST drive-by
die(_json_encode((object)['error' => true, 'msg' => 'POST required']));
}
// --- end added ---
$obj = new stdClass();
$obj->error = true;
$obj->msg = '';
$obj->id = intval(@$_POST['id']);
$obj->status = false;
if (empty($obj->id)) {
$obj->id = intval(@$_POST['comments_id']);
}
...
Stronger (recommended): also require a short-lived global token via verifyToken() as the in-source comment in objects/include_config.php prescribes, and audit every other objects/*.json.php handler that performs a write — the same omission likely affects additional endpoints and should be handled project-wide, ideally through a shared bootstrap that enforces forbidIfIsUntrustedRequest() for any json.php that mutates state.