Advisory

GHSA-8xwg-wv7v-4vqp

Also known as: CVE-2018-1000136

Summary

Electron Vulnerable to Code Execution by Re-Enabling Node.js Integration

Details

A vulnerability has been discovered which allows Node.js integration to be re-enabled in some Electron applications that disable it.

For the application to be impacted by this vulnerability it must meet all of these conditions

  • Runs on Electron 1.7, 1.8, or a 2.0.0-beta
  • Allows execution of arbitrary remote code
  • Disables Node.js integration
  • Does not explicitly declare webviewTag: false in its webPreferences
  • Does not enable the nativeWindowOption option
  • Does not intercept new-window events and manually override event.newGuest without using the supplied options tag

Recommendation

Update to electron version 1.7.13, 1.8.4, or 2.0.0-beta.5 or later.

If you are unable to update your Electron version can mitigate the vulnerability with the following code.

app.on('web-contents-created', (event, win) => {
  win.on('new-window', (event, newURL, frameName, disposition,
                        options, additionalFeatures) => {
    if (!options.webPreferences) options.webPreferences = {};
    options.webPreferences.nodeIntegration = false;
    options.webPreferences.nodeIntegrationInWorker = false;
    options.webPreferences.webviewTag = false;
    delete options.webPreferences.preload;
  })
})

// and *IF* you don't use WebViews at all,
// you might also want
app.on('web-contents-created', (event, win) => {
  win.on('will-attach-webview', (event, webPreferences, params) => {
    event.preventDefault();
  })
})

Severity

High Basis: The source's own band: HIGH

Dates

Published
2018-03-26 16:41 UTC
Modified
2023-11-08 03:59 UTC

Affected packages and fixes

electron

npm · All systems

Affected

  • introduced 1.7.0, fixed 1.7.13 (semver)

Fixed versions

1.7.13

Fix

electron

npm · All systems

Affected

  • introduced 1.8.0, fixed 1.8.4 (semver)

Fixed versions

1.8.4

Fix

electron

npm · All systems

Affected

  • introduced 2.0.0-beta.1, fixed 2.0.0-beta.5 (semver)

Fixed versions

2.0.0-beta.5

Fix

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences