Advisory

GHSA-9298-4cf8-g4wj

Also known as: CVE-2024-49768, PYSEC-2024-210

Summary

Waitress has request processing race condition in HTTP pipelining with invalid first request

Details

Impact

A remote client may send a request that is exactly recv_bytes (defaults to 8192) long, followed by a secondary request using HTTP pipelining.

When request lookahead is disabled (default) we won't read any more requests, and when the first request fails due to a parsing error, we simply close the connection.

However when request lookahead is enabled, it is possible to process and receive the first request, start sending the error message back to the client while we read the next request and queue it. This will allow the secondary request to be serviced by the worker thread while the connection should be closed.

Patches

Waitress 3.0.1 fixes the race condition.

Workarounds

Disable channel_request_lookahead, this is set to 0 by default disabling this feature. For this vulnerability this value is required to be changed from the default.

For more information

If you have any questions or comments about this advisory:

  • Open an issue in https://github.com/Pylons/waitress/issues (if not sensitive or security related)
  • email the Pylons Security mailing list: [[email protected]](mailto:[email protected]) (if security related)

Thanks

  • m4yfly and urn1ce From TianGong Team of Legendsec at Qi'anxin Group.

Severity

Critical Basis: The source's own band: CRITICAL

Dates

Published
2024-10-29 14:45 UTC
Modified
2025-01-21 18:22 UTC

Affected packages and fixes

waitress

PyPI · All systems

Affected

  • introduced 2.0.0, fixed 3.0.1 (ecosystem)

Fixed versions

3.0.1

Fix

  • Fixed version 3.0.1
    pip install --upgrade waitress==3.0.1

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences