Advisory

GHSA-93hq-5wgc-jc82

Also known as: CVE-2023-30542

Summary

GovernorCompatibilityBravo may trim proposal calldata

Details

Impact

The proposal creation entrypoint (propose) in GovernorCompatibilityBravo allows the creation of proposals with a signatures array shorter than the calldatas array. This causes the additional elements of the latter to be ignored, and if the proposal succeeds the corresponding actions would eventually execute without any calldata. The ProposalCreated event correctly represents what will eventually execute, but the proposal parameters as queried through getActions appear to respect the original intended calldata.

Patches

This issue has been patched in v4.8.3.

Workarounds

Ensure that all proposals that pass through governance have equal length signatures and calldatas parameters.

Severity

High Basis: The source's own band: HIGH

Dates

Published
2023-04-20 14:11 UTC
Modified
2023-11-08 04:12 UTC

Affected packages and fixes

@openzeppelin/contracts

npm · All systems

Affected

  • introduced 4.3.0, fixed 4.8.3 (semver)

Fixed versions

4.8.3

Fix

@openzeppelin/contracts-upgradeable

npm · All systems

Affected

  • introduced 4.3.0, fixed 4.8.3 (semver)

Fixed versions

4.8.3

Fix

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences