Details
| Attack | Impact |
|--------|--------|
| Access cloud metadata | Potentially access IAM credentials, API keys, or instance identity in certain cloud configurations |
| Internal service access | Read sensitive data from databases, Redis, admin panels |
| Network reconnaissance | Map internal network topology and services |
| Bypass firewalls | Access services not exposed to the internet |
---
Recommended Fix
Replace all requests.get() calls in download_service.py with safe_get() from security/safe_requests.py:
# download_service.py
+ from ...security.safe_requests import safe_get
def _download_generic(self, url, ...):
- response = requests.get(url, headers=headers, timeout=30)
+ response = safe_get(url, headers=headers, timeout=30)
The safe_get() function already validates URLs against SSRF attacks before making requests.
Files to update:
src/local_deep_research/research_library/services/download_service.py(9 occurrences)src/local_deep_research/research_library/downloaders/base.py(usesrequests.Session)
---
References
- CWE-918: Server-Side Request Forgery (SSRF)
- OWASP SSRF Prevention Cheat Sheet
- AWS SSRF Attacks and IMDSv2
- PortSwigger: SSRF
---
Thank you for your work on this project! I'm happy to provide any additional information or help with testing the fix.