Advisory

GHSA-9ffx-f77r-756w

Details, part 2 of 2. The advisory

Details

Step 4 - Override the services

Add to config/services.yaml.

Sylius 1.x (1.9 – 1.14):

services:
    # ... your existing services ...

    sylius.controller.shop.currency_switch:
        class: App\Controller\CurrencySwitchController
        public: true
        arguments:
            $templatingEngine: '@twig'
            $currencyStorage: '@sylius.storage.currency'
            $channelContext: '@sylius.context.channel'
            $router: '@router'

    sylius.controller.shop.impersonate_user:
        class: App\Controller\Admin\ImpersonateUserController
        public: true
        arguments:
            $impersonator: '@sylius.admin.security.user_impersonator'
            $authorizationChecker: '@security.authorization_checker'
            $userProvider: '@sylius.admin_user_provider.email_or_name_based'
            $router: '@router'
            $authorizationRole: 'ROLE_ADMINISTRATION_ACCESS'

    # Only if you use locale_switcher: storage
    sylius.shop.locale_switcher:
        class: App\Locale\StorageBasedLocaleSwitcher
        public: false
        arguments:
            $localeStorage: '@sylius.storage.locale'
            $channelContext: '@sylius.context.channel'
            $router: '@router'

Sylius 2.x (2.0 – 2.1):

services:
    # ... your existing services ...

    sylius_shop.controller.currency_switch:
        class: App\Controller\CurrencySwitchController
        public: true
        arguments:
            $currencyStorage: '@sylius.storage.currency'
            $channelContext: '@sylius.context.channel'
            $router: '@router'

    sylius_admin.controller.impersonate_user:
        class: App\Controller\Admin\ImpersonateUserController
        public: true
        arguments:
            $impersonator: '@sylius_admin.security.shop_user_impersonator'
            $authorizationChecker: '@security.authorization_checker'
            $userProvider: '@sylius.shop_user_provider.email_or_name_based'
            $router: '@router'
            $authorizationRole: 'ROLE_ADMINISTRATION_ACCESS'

    # Only if you use locale_switcher: storage
    sylius_shop.locale_switcher:
        class: App\Locale\StorageBasedLocaleSwitcher
        public: false
        arguments:
            $localeStorage: '@sylius.storage.locale'
            $channelContext: '@sylius.context.channel'
            $router: '@router'

Step 5 - Clear cache

bin/console cache:clear

---

Customizing the redirect target

If you need a different redirect target, override the route definition with the _sylius.redirect attribute:

# config/routes/sylius_shop.yaml (AFTER the sylius_shop resource import)
sylius_shop_switch_currency:
    path: /{_locale}/switch-currency/{code}
    methods: [GET]
    defaults:
        _controller: sylius.controller.shop.currency_switch:switchAction
        _sylius:
            redirect: sylius_shop_product_index  # or any route name

Reporters

We would like to extend our gratitude to the following individuals for their detailed reporting and responsible disclosure of this vulnerability:

  • Bartłomiej Nowiński (@bnBart)

For more information

If you have any questions or comments about this advisory:

Sources & licences