Advisory

GHSA-9mq6-mqjj-c2c5

Details, part 2 of 2. The advisory

Details

Local Gitea upload measurements:

| Entries | Upload HTTP status | Upload time | Uploaded bytes | Stored metadata bytes | Stored file count | Repository index blob bytes | Extracted files lines |
| ------: | -----------------: | ----------: | -------------: | --------------------: | ----------------: | --------------------------: | ----------------------: |
| 10,000 | 201 | 0.243 s | 47,461 | 450,112 | 10,000 | 27,267 | 10,001 |
| 100,000 | 201 | 0.483 s | 470,403 | 4,500,112 | 100,000 | 262,301 | 100,001 |
| 500,000 | 201 | 1.798 s | 2,349,767 | 22,500,112 | 500,000 | 1,306,465 | 500,001 |

Package Size Limit Behavior

I also tested LIMIT_SIZE_ARCH=1MiB with a non-admin package publisher.

| Entries | Upload bytes | Upload HTTP status | Stored metadata bytes | Notes |
| ------: | -----------: | -----------------: | --------------------: | ------------------------------------------------------------------------ |
| 100,000 | 470,403 | 201 | 4,500,112 | Accepted because the compressed upload was below the package size limit. |
| 500,000 | 2,349,767 | 403 | not stored | Rejected with maximum allowed package type size exceeded. |

This suggests that the compressed package size limit helps reduce exposure, but it may not fully address metadata growth for highly compressible archives that stay below the configured upload limit.

Expected Behavior

Gitea should ideally reject package archives whose expanded package metadata would require excessive server-side resources. It would be safer if this validation happened before the file list is serialized, persisted, or used during repository index generation.

Suggested Remediation

One possible mitigation would be to add explicit bounds during Arch package metadata parsing before the file list is stored or used for repository index generation.

Potential controls could include:

  • limiting the maximum number of regular file entries recorded in FileMetadata.Files
  • limiting the cumulative byte length of recorded file names
  • returning a clear 4xx validation error when an uploaded package exceeds those limits
  • optionally making these limits configurable for instance operators
  • adding regression tests for excessive file-entry count and excessive cumulative file-name size

For example, the validation could follow this general shape:

const (
	maxArchMetadataFiles = 10000
	maxArchMetadataFileNameBytes = 1 << 20
)

var totalFileNameBytes int

// inside the tar entry loop
if !strings.HasPrefix(filename, ".") {
	totalFileNameBytes += len(hd.Name)
	if len(files) >= maxArchMetadataFiles || totalFileNameBytes > maxArchMetadataFileNameBytes {
		return nil, util.NewInvalidArgumentErrorf("arch package file metadata exceeds limit")
	}
	files = append(files, hd.Name)
}

This is only a suggested direction, and I understand the project may prefer a different threshold or design depending on compatibility and package registry requirements.

Closing

Thank you for taking the time to review this report. Please let me know if any additional information would be helpful, such as the local test environment details, database inspection steps, or additional measurements with different limits.

I appreciate your work on maintaining Gitea and would be happy to help clarify or retest any proposed fix.

Sources & licences