github.com/syncthing/syncthing
Affected
- introduced
0, fixed1.23.5(semver)
Fixed versions
1.23.5
Fix
- Fixed version
1.23.5go get github.com/syncthing/[email protected]
Advisory
Also known as: BIT-syncthing-2022-46165, CVE-2022-46165
syncthing vulnerable to Cross-site Scripting (XSS) in Web GUI
Impact
If the owner of another device looks over the shared folder settings and moves the mouse over the latest sync, a script could be executed to change settings for shared folders or add devices automatically.
Risk
As long as trusted devices are used, the risk is low.
Additionally, the web GUI is not used that often in daily use which reduces the likelihood of exploitation.
Details
1. Field "Latest Change"
<img src=a onerror=alert(123)> and sync it to the other instance.<img width="834" alt="latest-change" src="https://user-images.githubusercontent.com/9484134/205084362-20a8ec13-a88d-469f-bdf1-e5291c20f4c1.png">
Web browser source
<span tooltip="" data-original-title="\"><img src=a onerror=alert(123)> @ 2022-11-30 16:58:43"
aria-describedby="tooltip409527">
<!-- ngIf: !folderStats[folder.id].lastFile.deleted --><span translate=""
translate-value-file=""><img src=a onerror=alert(123)>" ng-if="!folderStats[folder.id].lastFile.deleted"
class="ng-scope">Updated "><img src=a onerror=alert(123)></span>
<!-- end ngIf: !folderStats[folder.id].lastFile.deleted -->
<!-- ngIf: folderStats[folder.id].lastFile.deleted -->
</span>
<div class="tooltip fade top in" role="tooltip" id="tooltip409527"
style="top: 446.033px; left: 318.3px; display: block;">
<div class="tooltip-arrow" style="left: 50%;"></div>
<div class="tooltip-inner">\"><img src="a" onerror="alert(123)"> @ 2022-11-30 16:58:43</div>
</div>
Corresponding code in the project
File gui/default/index.html:
<tr ng-if="folder.type != 'sendonly' && folder.type != 'receiveencrypted' && folderStats[folder.id].lastFile && folderStats[folder.id].lastFile.filename">
<th><span class="fas fa-fw fa-exchange-alt"></span> <span translate>Latest Change</span></th>
<td class="text-right">
<span tooltip data-original-title="{{folderStats[folder.id].lastFile.filename}} @ {{folderStats[folder.id].lastFile.at | date:'yyyy-MM-dd HH:mm:ss'}}">
<span translate translate-value-file="{{folderStats[folder.id].lastFile.filename | basename}}" ng-if="!folderStats[folder.id].lastFile.deleted">Updated {%file%}</span>
<span translate translate-value-file="{{folderStats[folder.id].lastFile.filename | basename}}" ng-if="folderStats[folder.id].lastFile.deleted">Deleted {%file%}</span>
</span>
</td>
</tr>
File gui/default/syncthing/core/tooltipDirective.js:
angular.module('syncthing.core')
.directive('tooltip', function () {
return {
restrict: 'A',
link: function (scope, element, attributes) {
$(element).tooltip({
html: 'true'
});
}
};
});
The attribute html should not be set to true or input sanitized.
2. Field "Shared With"
fedora 1"'><h1>Headline</h1><img src=x><script>alert(1)</script>.<img width="608" alt="shared-with-1" src="https://user-images.githubusercontent.com/9484134/205084172-8cab2d0e-3257-46d5-be81-41fbd7228e0c.png">
Web browser source
<span tooltip="" data-original-title="fedora 1"'><h1>Headline</h1><img src=x><script>alert(1)</script> "
ng-bind-html="sharesFolder(folder)" class="ng-binding" aria-describedby="tooltip348410">fedora 1"'><h1>Headline
</h1><img src="x"></span>
<div class="tooltip fade top" role="tooltip" id="tooltip348410" style="top: 0px; left: 0px; display: block;">
<div class="tooltip-arrow" style="left: 50%;"></div>
<div class="tooltip-inner">fedora 1"'><h1>Headline</h1><img src="x">
<script>alert(1)</script>
</div>
</div>
Corresponding code in the project
File gui/default/index.html:
<tr>
<th><span class="fas fa-fw fa-share-alt"></span> <span translate>Shared With</span></th>
<td class="text-right">
<span tooltip data-original-title="{{sharesFolder(folder)}} {{folderHasUnacceptedDevices(folder) ? '<br/>(<sup>1</sup>' + ('The remote device has not accepted sharing this folder.' | translate) + ')' : ''}} {{folderHasPausedDevices(folder) ? '<br/>(<sup>2</sup>' + ('The remote device has paused this folder.' | translate) + ')' : ''}}" ng-bind-html="sharesFolder(folder)"></span>
</td>
</tr>
File gui/default/syncthing/core/tooltipDirective.js:
angular.module('syncthing.core')
.directive('tooltip', function () {
return {
restrict: 'A',
link: function (scope, element, attributes) {
$(element).tooltip({
html: 'true'
});
}
};
});
The attribute html should not be set to true or input sanitized.
HTML Injection in "Edit Folder"
<img width="672" alt="shared-with-2" src="https://user-images.githubusercontent.com/9484134/205084067-b33f8536-e350-4de1-86f6-3d4a12a683c3.png">
Medium Basis: The source's own band: MODERATE
0, fixed 1.23.5 (semver)1.23.5
1.23.5go get github.com/syncthing/[email protected]Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.
Check your own computer: guard packages check
Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0