@saltcorn/server
Affected
- introduced
0, fixed1.0.0-beta.14(semver)
Fixed versions
1.0.0-beta.14
Fix
- Fixed version
1.0.0-beta.14npm install @saltcorn/[email protected]
Advisory
Also known as: None
@saltcorn/server arbitrary file and directory listing when accessing build mobile app results
Summary
A user with admin permission can read arbitrary file and directory names on the filesystem by calling the admin/build-mobile-app/result?build_dir_name= endpoint. The build_dir_name parameter is not properly validated and it's then used to construct the buildDir that is read. The file/directory names under the buildDir will be returned.
Details
router.get(
"/build-mobile-app/result",
isAdmin,
error_catcher(async (req, res) => {
const { build_dir_name } = req.query; // [1] source
const rootFolder = await File.rootFolder();
const buildDir = path.join(
rootFolder.location,
"mobile_app",
build_dir_name // [2]
);
const files = await Promise.all(
fs
.readdirSync(buildDir) // [3] sink
.map(async (outFile) => await File.from_file_on_disk(outFile, buildDir))
);
[...]
})
);
PoC
http://localhost:3000/admin/build-mobile-app/result?build_dir_name=/../../../../../../../../NOTE: it's possible to only see file and directory names but not to download their content.
Impact
Information disclosure
Recommended Mitigation
Resolve the buildDir and check if it starts with ${rootFolder.location}/mobile_app.
Medium Basis: The source's own band: MODERATE
0, fixed 1.0.0-beta.14 (semver)1.0.0-beta.14
1.0.0-beta.14npm install @saltcorn/[email protected]Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.
Check your own computer: guard packages check
Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0