Advisory

GHSA-cv65-7cg8-r623

Details, part 2 of 2. The advisory

Details

HTTP/1.1 200 OK
Cache-Control: public, max-age=31536000, immutable
Content-Length: 215
Content-Type: application/pdf

%PDF-FAKE-CONTENT for FacturaScripts PoC
...

<img width="1582" height="789" alt="03-exploit-path2-myfiles-public-token-bypass" src="https://github.com/user-attachments/assets/2f95d0c1-4545-453c-a613-5ed035af7957" />

A quick check shows that several encoding variants of .. also work: %2e%2e, %2E%2E, .%2e, ///../. The flaw lives in the prefix check, not in any specific Apache normalization.

The file is confirmed present on disk:

<img width="1918" height="328" alt="04-lab-evidence-file-on-disk" src="https://github.com/user-attachments/assets/2db5875a-d349-4861-bbdd-8f202eb80d5a" />

Affected request paths

| URL pattern | Controller | Token required | Result |
|---|---|---|---|
| /MyFiles/Private/invoice.pdf | Myfiles | yes | 403 (control) |
| /Plugins/../MyFiles/Private/invoice.pdf | Files | n/a | 200 (leak) |
| /Core/Assets/../MyFiles/Private/invoice.pdf | Files | n/a | 200 (leak) |
| /Dinamic/Assets/../MyFiles/Private/invoice.pdf | Files | n/a | 200 (leak) |
| /MyFiles/Public/../Private/invoice.pdf | Myfiles | bypassed | 200 (leak) |

Impact

In a real ERP deployment this exposes the documents that the application is specifically designed to keep behind a per-file token:

  • Customer and supplier invoices stored under MyFiles/Private/
  • Document attachments uploaded through WidgetFile and DocFilesTrait (MyFiles/<filename>)
  • Database backups exported with .sql
  • Cached or temporary business data under MyFiles/Cache/ and MyFiles/Tmp/

.php files are not on the extension allow-list, so the flaw does not lead to remote code execution. Files outside the FacturaScripts installation are rejected by Apache's URI normalization (AH10244 invalid URI path), so the leak is bounded to the application directory tree.

Suggested Fix

Both controllers should resolve the requested path to its canonical form with realpath() and verify that the canonical path is inside an allow-listed directory before serving the file or skipping the token
check. Example for Files::__construct:

$this->filePath = Tools::folder() . $url;

if (false === is_file($this->filePath)) {
    throw new KernelException('FileNotFound', ...);
}

$realPath = realpath($this->filePath);
$base = realpath(Tools::folder());
if ($realPath === false || strpos($realPath, $base . DIRECTORY_SEPARATOR) !== 0) {
    throw new KernelException('UnsafeFolder', $url);
}

$safeFolders = ['node_modules', 'vendor', 'Dinamic', 'Core', 'Plugins', 'MyFiles' . DIRECTORY_SEPARATOR . 'Public'];
$relative = substr($realPath, strlen($base) + 1);
$allowed = false;
foreach ($safeFolders as $folder) {
    if (strpos($relative, $folder . DIRECTORY_SEPARATOR) === 0) {
        $allowed = true;
        break;
    }
}
if (!$allowed) {
    throw new KernelException('UnsafeFolder', $url);
}

The same pattern applies to Myfiles::__construct: compare the canonical resolved path against realpath(Tools::folder() . '/MyFiles/Public') before skipping the myft token check.

Affected Versions

Confirmed on the current master branch (commit de01369) and on the latest tagged release (v2026.2).

Sources & licences