Advisory

GHSA-cx2q-hfxr-rj97

Also known as: CVE-2023-42460, PYSEC-2023-191

Summary

Vyper's _abi_decode input not validated in complex expressions

Details

Impact
_abi_decode() does not validate input when it is nested in an expression. the following example gets correctly validated (bounds checked):

x: int128 = _abi_decode(slice(msg.data, 4, 32), int128)

however, the following example is not bounds checked

@external
def abi_decode(x: uint256) -> uint256:
    a: uint256 = convert(_abi_decode(slice(msg.data, 4, 32), (uint8)), uint256) + 1
    return a  # abi_decode(256) returns: 257

the issue can be triggered by constructing an example where the output of _abi_decode is not internally passed to make_setter (an internal codegen routine) or other input validating routine.

Patches
https://github.com/vyperlang/vyper/pull/3626

Workarounds
_Is there a way for users to fix or remediate the vulnerability without upgrading?_

References
_Are there any links users can visit to find out more?_

Severity

Medium Basis: The source's own band: MODERATE

Dates

Published
2023-09-26 19:34 UTC
Modified
2024-11-19 17:33 UTC

Affected packages and fixes

vyper

PyPI · All systems

Affected

  • introduced 0.3.4, fixed 0.3.10 (ecosystem)

Fixed versions

0.3.10

Fix

  • Fixed version 0.3.10
    pip install --upgrade vyper==0.3.10

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences