gix-attributes
Affected
- introduced
0, fixed0.22.3(semver)
Fixed versions
0.22.3
Fix
- Fixed version
0.22.3cargo update -p gix-attributes --precise 0.22.3
Advisory
Also known as: RUSTSEC-2024-0359
The kstring integration in gix-attributes is unsound
gix-attributes (in `state::ValueRef`) unsafely creates a &str from a &[u8] containing non-UTF8 data, with the justification that so long as nothing reads the &str and relies on it being UTF-8 in the &str, there is no UB:
// SAFETY: our API makes accessing that value as `str` impossible, so illformed UTF8 is never exposed as such.
The problem is that the non-UTF8 str is exposed to outside code: first to the kstring crate itself, which requires UTF-8 in its documentation and may have UB as a consequence of this, but also to serde, where it propagates to e.g. serde_json, serde_yaml, etc., where the same problems occur.
This is not sound, and it could cause further UB down the line in these places that can view the &str.
Low Basis: The source's own band: LOW
0, fixed 0.22.3 (semver)0.22.3
0.22.3cargo update -p gix-attributes --precise 0.22.3Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.
Check your own computer: guard packages check
Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0