Advisory

GHSA-f598-mfpv-gmfx

Also known as: CVE-2023-22578

Summary

Sequelize - Default support for “raw attributes” when using parentheses

Details

Impact

Sequelize 6.28.2 and prior has a dangerous feature where using parentheses in the attribute option would make Sequelize use the string as-is in the SQL

User.findAll({
  attributes: [
    ['count(id)', 'count']
  ]
});

Produced

SELECT count(id) AS "count" FROM "users"

Patches

This feature was deprecated in Sequelize 5, and using it prints a deprecation warning.

This issue has been patched in `@sequelize/[email protected]` and `[email protected]`.

In Sequelize 7, it now produces the following:

SELECT "count(id)" AS "count" FROM "users"

In Sequelize 6, it throws an error explaining that we had to introduce a breaking change, and requires the user to explicitly opt-in to either the Sequelize 7 behavior (always escape) or the Sequelize 5 behavior (inline attributes that include () without escaping). See https://github.com/sequelize/sequelize/pull/15710 for more information.

Mitigations

Do not use user-provided content to build your list or attributes. If you do, make sure that attribute in question actually exists on your model by checking that it exists in the rawAttributes property of your model first.

---

A discussion thread about this issue is open at https://github.com/sequelize/sequelize/discussions/15694
CVE: CVE-2023-22578

Severity

Critical Basis: The source's own band: CRITICAL

Dates

Published
2023-02-24 18:48 UTC
Modified
2023-11-08 04:11 UTC

Affected packages and fixes

@sequelize/core

npm · All systems

Affected

  • introduced 0, fixed 7.0.0-alpha.20 (semver)

Fixed versions

7.0.0-alpha.20

Fix

sequelize

npm · All systems

Affected

  • introduced 0, fixed 6.29.0 (semver)

Fixed versions

6.29.0

Fix

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences