Advisory

GHSA-fpq5-4vwm-78x4

Also known as: CVE-2023-48294

Summary

LibreNMS has Broken Access control on Graphs Feature

Details

Summary
This vulnerability occurs when application is not checking access of each type of users as per their role and it autorizing the users to access any feature. When user access his Device dashboard in librenms, one request is going to graph.php to access image of graphs generated on the particular Device. This request can be accessed by lower privileged users as well and they can enumerate devices on librenms with their id or hostname.

Details
_Give all details on the vulnerability. Pointing to the incriminated source code is very helpful for the maintainer._

PoC

  1. Login with Lower privilege user
  2. Go to /graph.php?width=150&height=45&device=1&type=device_ping_perf&from=1699022192&legend=no&bg=FFFFFF00&popup_title=ICMP+Response
  3. If its showing image with "device*ping_perf" which confirms that there is device with id 1
  4. Now you can change device parameter in above URL with hostname to check if that Hostname/IP exist or not like

http://127.0.0.1:8000/graph.php?width=150&height=45&device=127.0.0.1&type=device_ping_perf&from=1699022192&legend=no&bg=FFFFFF00&popup_title=ICMP+Response

  1. If device hostname doesn't exist then it should show 500 error

Check attached screenshots for more info

Vulnerable code:
https://github.com/librenms/librenms/blob/fa93034edd40c130c2ff00667ca2498d84be6e69/html/graph.php#L19C1-L25C2

Above is vulnerable line of code from Line number 19-25
This is not checking privilege of users to access any device hostname, its just checking if user is authenticated
or not

Impact
Low privilege users can see all devices registered by admin users by using this method

Solution
Implement privilege access control feature to check if low privilege user have access or not.

Screenshots:-
<img width="967" alt="Screenshot 2023-11-04 at 8 31 15 PM" src="https://user-images.githubusercontent.com/31764504/281085588-1c5d81b9-83d7-4ba8-baf3-03c95a99cefe.png">
<img width="973" alt="Screenshot 2023-11-04 at 8 31 36 PM" src="https://user-images.githubusercontent.com/31764504/281085614-7a4d13b0-d316-4d24-bdd2-05c3a80ffd59.png">
<img width="955" alt="Screenshot 2023-11-04 at 8 31 48 PM" src="https://user-images.githubusercontent.com/31764504/281085629-43aa2b6f-7b18-415f-8001-519bda45f918.png">

Severity

Medium Basis: The source's own band: MODERATE

Dates

Published
2023-11-17 21:51 UTC
Modified
2024-02-16 08:17 UTC

Affected packages and fixes

librenms/librenms

Packagist · All systems

Affected

  • introduced 0, fixed 23.11.0 (ecosystem)

Fixed versions

23.11.0

Fix

The export has no generic command for this ecosystem.

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences