Details
=== SCENARIO A (control): both sides default (maxpacket 32768) ===
[server] read 5 bytes; echoing via AsyncWrite ...
[server] echo write completed
RESULT A: echo received: "hello"
=== SCENARIO B: client advertises maximum_packet_size = 0 ===
[server] read 5 bytes; echoing via AsyncWrite ...
RESULT B: TIMEOUT after 6s - server-side echo write is permanently stalled (no error, no data)
=== SCENARIO C: server advertises maximum_packet_size = 0 ===
RESULT C: TIMEOUT after 6s - client-side channel.data() is permanently stalled
The server task stays parked inside ChannelTx::poll_writable; nothing is logged and nothing is returned to the handler. The harness source (server: into_stream() echo; client: one config toggle) can be attached on request.
Unit-level sketch of the core defect:
let mut tx = ChannelTx::<Msg>::new(
sender, ChannelId(0),
Arc::new(Mutex::new(4096)), // window_size
Arc::new(Notify::new()), // notify
0, // max_packet_size
None,
);
// poll_write(&mut tx, cx, b"x") stays Poll::Pending forever,
// even after CHANNEL_WINDOW_ADJUST raises `window_size`.
Suggested fix
- Validate at parse time (preferred): reject
maximum_packet_size == 0withError::InconsistentinOpenChannelMessage::parseandChannelOpenConfirmation::decode(russh/src/parsing.rs), consistent with the existing guards; optionally clamp any value below the RFC 4254 recommended minimum (32768) instead. - Defense in depth: in
ChannelTx::poll_writable(russh/src/channels/io/tx.rs:82), whenself.max_packet_size == 0, surface anio::Errorfrompoll_writeinstead of returningPoll::Pending.
Both match the treatment PR #695 already applied to the other write paths in v0.61.0 (the reserve_writable_chunk and session packetizer guards).
Affected versions
Verified by inspecting the release artifacts: 0.60.0 through 0.64.1 (current) are affected - poll_writable is byte-identical in v0.60.0 and the peer-value plumbing is present in all of them. The ChannelTx write logic and the peer-value flow predate 0.60 (they go back to the channels::io refactor), so we recommend treating all releases that ship channels::io::ChannelTx as affected. The zero-guards in the other write paths were only added in 0.61.0, so on 0.60.x those paths do not even fail with an error.
Reporter
Tshellauth