@sveltejs/kit
Affected
- introduced
2.0.0, fixed2.4.3(semver)
Fixed versions
2.4.3
Fix
- Fixed version
2.4.3npm install @sveltejs/[email protected]
Advisory
Also known as: CVE-2024-23641
Sending a GET or HEAD request with a body crashes SvelteKit
Summary
In SvelteKit 2 sending a GET request with a body eg {} to a SvelteKit app in preview or with adapter-node throws Request with GET/HEAD method cannot have body. and crashes the app.
node:internal/deps/undici/undici:6066
throw new TypeError("Request with GET/HEAD method cannot have body.");
^
TypeError: Request with GET/HEAD method cannot have body.
at new Request (node:internal/deps/undici/undici:6066:17)
at getRequest (file:///C:/Users/admin/Desktop/reproduction/node_modules/@sveltejs/kit/src/exports/node/index.js:107:9)
at file:///C:/Users/admin/Desktop/reproduction/node_modules/@sveltejs/kit/src/exports/vite/preview/index.js:181:26
at call (file:///C:/Users/admin/Desktop/reproduction/node_modules/vite/dist/node/chunks/dep-9A4-l-43.js:44795:7)
at next (file:///C:/Users/admin/Desktop/reproduction/node_modules/vite/dist/node/chunks/dep-9A4-l-43.js:44739:5)
at file:///C:/Users/admin/Desktop/reproduction/node_modules/@sveltejs/kit/src/exports/vite/preview/index.js:172:6
at call (file:///C:/Users/admin/Desktop/reproduction/node_modules/vite/dist/node/chunks/dep-9A4-l-43.js:44795:7)
at next (file:///C:/Users/admin/Desktop/reproduction/node_modules/vite/dist/node/chunks/dep-9A4-l-43.js:44739:5)
at file:///C:/Users/admin/Desktop/reproduction/node_modules/@sveltejs/kit/src/exports/vite/preview/index.js:211:27
at call (file:///C:/Users/admin/Desktop/reproduction/node_modules/vite/dist/node/chunks/dep-9A4-l-43.js:44795:7)
Node.js v20.11.0
TRACE requests will also cause the app to crash. Prerendered pages and SvelteKit 1 apps are not affected.
<!--
Details
_Give all details on the vulnerability. Pointing to the incriminated source code is very helpful for the maintainer._
-->
PoC
<!-- _Complete instructions, including specific configuration details, to reproduce the vulnerability._ -->
First do a fresh install of SvelteKit 2 with the example app. Typescript.
npm run buildnpm run previewImpact
<!-- _What kind of vulnerability is it? Who is impacted?_ -->
Denial of Service for apps using adapter-node
High Basis: The source's own band: HIGH
2.0.0, fixed 2.4.3 (semver)2.4.3
2.4.3npm install @sveltejs/[email protected]2.0.0, fixed 2.1.2 (semver)2.1.2
2.1.2npm install @sveltejs/[email protected]3.0.0, fixed 3.0.3 (semver)3.0.3
3.0.3npm install @sveltejs/[email protected]4.0.0, fixed 4.0.1 (semver)4.0.1
4.0.1npm install @sveltejs/[email protected]Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.
Check your own computer: guard packages check
Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0