Advisory

GHSA-gc7p-j5xm-xxh2

Also known as: CVE-2023-39345

Summary

Unauthorized Access to Private Fields in User Registration API

Details

System Details
| Name | Value |
|----------|------------------------|
| OS | Windows 11 |
| Version | 4.11.1 (node v16.14.2) |
| Database | mysql |

Description
I marked some fields as private fields in user content-type, and tried to register as a new user via api, at the same time I added content to fill the private fields and sent a post request, and as you can see from the images below, I can write to the private fields.

register

user

private_field

table

To prevent this, I went to the extension area and tried to extend the register method, for this I wanted to do it using the sanitizeInput function that I know in the source codes of the strap. But the sanitizeInput function did not filter out private fields.

  const { auth } = ctx.state;
  const data = ctx.request.body;
  const userSchema = strapi.getModel("plugin::users-permissions.user");

  sanitize.contentAPI.input(data, userSchema, { auth });

here's the solution I've temporarily kept to myself, code snippet

  const body = ctx.request.body;

  const { attributes } = strapi.getModel("plugin::users-permissions.user");

  const sanitizedData = _.omitBy(body, (data, key) => {
    const attribute = attributes[key];

    if (_.isNil(attribute)) {
      return false;
    }

    //? If you want, you can throw an error for fields that we did not expect.

    // if (_.isNil(attribute))
    //   throw new ApplicationError(`Unexpected value ${key}`);

    // if private value is true, we do not want to send it to the database.
    return attribute.private;
  });

  return sanitizedData;

Severity

High Basis: The source's own band: HIGH

Dates

Published
2023-11-03 19:01 UTC
Modified
2023-11-08 04:13 UTC

Affected packages and fixes

@strapi/plugin-users-permissions

npm · All systems

Affected

  • introduced 4.0.0, fixed 4.13.1 (semver)

Fixed versions

4.13.1

Fix

@strapi/strapi

npm · All systems

Affected

  • introduced 4.0.0, fixed 4.13.1 (semver)

Fixed versions

4.13.1

Fix

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences