Advisory

GHSA-gcx2-gvj7-pxv3

Also known as: CVE-2022-24766, PYSEC-2022-170

Summary

Insufficient Protection against HTTP Request Smuggling in mitmproxy

Details

Impact

In mitmproxy 7.0.4 and below, a malicious client or server is able to perform HTTP request smuggling attacks through mitmproxy. This means that a malicious client/server could smuggle a request/response through mitmproxy as part of another request/response's HTTP message body. While mitmproxy would only see one request, the target server would see multiple requests. A smuggled request is still captured as part of another request's body, but it does not appear in the request list and does not go through the usual mitmproxy event hooks, where users may have implemented custom access control checks or input sanitization.

Unless you use mitmproxy to protect an HTTP/1 service, no action is required.

Patches

The vulnerability has been fixed in mitmproxy 8.0.0 and above.

Acknowledgements

We thank Zeyu Zhang (@zeyu2001) for responsibly disclosing this vulnerability to the mitmproxy team.

Timeline

  • 2022-03-15: Received initial report.
  • 2022-03-15: Verified report and confirmed receipt.
  • 2022-03-16: Shared patch with researcher.
  • 2022-03-16: Received confirmation that patch is working.
  • 2022-03-19: Published patched release and advisory.

Severity

Critical Basis: The source's own band: CRITICAL

Dates

Published
2022-03-22 19:22 UTC
Modified
2025-02-22 05:12 UTC

Affected packages and fixes

mitmproxy

PyPI · All systems

Affected

  • introduced 0, fixed 8.0.0 (ecosystem)

Fixed versions

8.0.0

Fix

  • Fixed version 8.0.0
    pip install --upgrade mitmproxy==8.0.0

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences