github.com/cloudflare/tableflip
Affected
- introduced
0, fixed1.2.2(semver)
Fixed versions
1.2.2
Fix
- Fixed version
1.2.2go get github.com/cloudflare/[email protected]
Advisory
Also known as: None
A failed upgrade may lead to hung goroutines
Impact
Processes using tableflip may encounter hung goroutines in the parent process, after a failed upgrade.
The Go runtime has annoying behaviour around setting and clearing
O_NONBLOCK: exec.Cmd.Start() ends up calling os.File.Fd() for any
file in exec.Cmd.ExtraFiles. os.File.Fd() disables both the use
of the runtime poller for the file and clears O_NONBLOCK from
the underlying open file descriptor.
This can lead to goroutines hanging in a parent process, after at least
one failed upgrade. The bug manifests in goroutines which rely on
either a deadline or interruption via Close() to be unblocked being stuck
in read or accept like syscalls. As far as I can tell we've not experienced
this problem in production, so it's most likely quite rare.
Patches
The problem has been fixed in v1.2.2.
Workarounds
None.
References
Low Basis: The source's own band: LOW
0, fixed 1.2.2 (semver)1.2.2
1.2.2go get github.com/cloudflare/[email protected]Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.
Check your own computer: guard packages check
Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0