Advisory

GHSA-gpfh-jvf9-7wg5

Also known as: BIT-tensorflow-2021-41220, CVE-2021-41220, PYSEC-2021-412, PYSEC-2021-629, PYSEC-2021-827

Summary

Use after free / memory leak in CollectiveReduceV2

Details

Impact
The async implementation of CollectiveReduceV2 suffers from a memory leak and a use after free:

import tensorflow as tf
  
tf.raw_ops.CollectiveReduceV2(
  input=[],
  group_size=[-10, -10, -10],
  group_key=[-10, -10],
  instance_key=[-10],
  ordering_token=[],
  merge_op='Mul',
  final_op='Div')

This occurs due to the asynchronous computation and the fact that objects that have been std::move()d from are still accessed:

auto done_with_cleanup = [col_params, done = std::move(done)]() {
  done();
  col_params->Unref();
};
OP_REQUIRES_OK_ASYNC(c,
                     FillCollectiveParams(col_params, REDUCTION_COLLECTIVE,
                                          /*group_size*/ c->input(1),
                                          /*group_key*/ c->input(2),
                                          /*instance_key*/ c->input(3)),
                     done);

Here, done is already moved from by the time OP_REQUIRES_OK_ASYNC macro needs to invoke it in case of errors. In this case, we get an undefined behavior, which can manifest via crashes, std::bad_alloc throws or just memory leaks.

Patches
We have patched the issue in GitHub commit ca38dab9d3ee66c5de06f11af9a4b1200da5ef75.

The fix will be included in TensorFlow 2.7.0. We will also cherrypick this commit on TensorFlow 2.6.1, as this version is the only one that is also affected.

For more information
Please consult our security guide for more information regarding the security model and how to contact us with issues and questions.

Attribution
This vulnerability has been reported by members of the Aivul Team from Qihoo 360.

Severity

High Basis: The source's own band: HIGH

Dates

Published
2021-11-10 18:51 UTC
Modified
2026-07-08 06:28 UTC

Affected packages and fixes

tensorflow

PyPI · All systems

Affected

  • introduced 2.6.0, fixed 2.6.1 (ecosystem)

Fixed versions

2.6.1

Fix

  • Fixed version 2.6.1
    pip install --upgrade tensorflow==2.6.1

tensorflow-cpu

PyPI · All systems

Affected

  • introduced 2.6.0, fixed 2.6.1 (ecosystem)

Fixed versions

2.6.1

Fix

  • Fixed version 2.6.1
    pip install --upgrade tensorflow-cpu==2.6.1

tensorflow-gpu

PyPI · All systems

Affected

  • introduced 2.6.0, fixed 2.6.1 (ecosystem)

Fixed versions

2.6.1

Fix

  • Fixed version 2.6.1
    pip install --upgrade tensorflow-gpu==2.6.1

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences