github.com/runatlantis/atlantis
Affected
- introduced
0, fixed0.30.0(semver)
Fixed versions
0.30.0
Fix
- Fixed version
0.30.0go get github.com/runatlantis/[email protected]
Advisory
Also known as: CVE-2024-52009, GO-2024-3265
Git credentials are exposed in Atlantis logs
Summary
_Short summary of the problem. Make the impact and severity as clear as possible. For example: An unsafe deserialization vulnerability allows any unauthenticated user to execute arbitrary code on the server._
Atlantis logs contains GitHub credentials (tokens ghs_...) when they are rotated. This enables an attacker able to read these logs to impersonate Atlantis application and to perform actions on GitHub.
When Atlantis is used to administer a GitHub organization, this enables getting administration privileges on the organization.
This was reported in https://github.com/runatlantis/atlantis/issues/4060 and fixed in https://github.com/runatlantis/atlantis/pull/4667 . The fix was included in Atlantis v0.30.0.
Details
_Give all details on the vulnerability. Pointing to the incriminated source code is very helpful for the maintainer._
While auditing the Kubernetes/Argo CD/Atlantis deployment of some company, the following set-up was encountered:
Atlantis logs on Argo CD contained lines such as:
{"level":"debug","ts":"2024-11-07T17:58:30.636Z","caller":"vcs/gh_app_creds_rotator.go:58","msg":"Refreshing git tokens for Github App","json":{}}
{"level":"debug","ts":"2024-11-07T17:58:30.637Z","caller":"vcs/gh_app_creds_rotator.go:64","msg":"token ghs_[REDACTED]","json":{}}
{"level":"debug","ts":"2024-11-07T17:58:30.637Z","caller":"vcs/git_cred_writer.go:36","msg":"git credentials file has expected contents, not modifying","json":{}}
This enabled employees with read-only access to Argo CD to get administration privileges on the GitHub organization, compromising all repositories. As some repositories were used for Infrastructure-as-Code deployment (with Atlantis), this enabled the security auditors to get cluster admin privileges on most Kubernetes clusters.
While the set-up "most employees have read-only access to Argo CD" can be seen as dangerous, this should not incur such security risk (cf. https://argo-cd.readthedocs.io/en/stable/operator-manual/security/). The main issue here was that the logs contained privileged GitHub tokens as they were obtained by Atlantis.
This issue was already reported (https://github.com/runatlantis/atlantis/issues/4060) and fixed (https://github.com/runatlantis/atlantis/pull/4667) but no security advisory was published on https://github.com/runatlantis/atlantis/security and no CVE was assigned (https://app.opencve.io/cve/?&vendor=runatlantis&product=atlantis only lists CVE-2022-24912, which is unrelated).
Could you please publish a security advisory?
PoC
_Complete instructions, including specific configuration details, to reproduce the vulnerability._
cf. https://github.com/runatlantis/atlantis/issues/4060 for more details.
Impact
_What kind of vulnerability is it? Who is impacted?_
High Basis: The source's own band: HIGH
0, fixed 0.30.0 (semver)0.30.0
0.30.0go get github.com/runatlantis/[email protected]Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.
Check your own computer: guard packages check
Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0