Advisory

GHSA-h4w9-6x78-8vrj

Also known as: CVE-2022-31035, GO-2022-0498

Summary

Argo CD's external URLs for Deployments can include JavaScript

Details

Impact

All unpatched versions of Argo CD starting with v1.0.0 are vulnerable to a cross-site scripting (XSS) bug allowing a malicious user to inject a javascript: link in the UI. When clicked by a victim user, the script will execute with the victim's permissions (up to and including admin).

The script would be capable of doing anything which is possible in the UI or via the API, such as creating, modifying, and deleting Kubernetes resources.

Patches

A patch for this vulnerability has been released in the following Argo CD versions:

  • v2.4.1
  • v2.3.5
  • v2.2.10
  • v2.1.16

Workarounds

There are no completely-safe workarounds besides upgrading.

Mitigations:

  1. Avoid clicking external links presented in the UI. Here is an example of an Application node with an external link:

Application node in the Argo CD UI with an external link

The link's title is user-configurable. So even if you hover the link, and the tooltip looks safe, the link might be malicious. The only way to be certain that the link is safe is to inspect the page's source.

  1. Carefully limit who has permissions to edit resource manifests (this is configured in RBAC).

References

Credits

Disclosed by ADA Logics in a security audit of the Argo project sponsored by CNCF and facilitated by OSTIF. Thanks to Adam Korczynski and David Korczynski for their work on the audit.

For more information

Severity

Critical Basis: The source's own band: CRITICAL

Dates

Published
2022-06-21 20:04 UTC
Modified
2024-08-21 15:41 UTC

Affected packages and fixes

github.com/argoproj/argo-cd

Go · All systems

Affected

  • introduced 1.0.0, fixed 2.1.16 (semver)

Fixed versions

2.1.16

Fix

github.com/argoproj/argo-cd/v2

Go · All systems

Affected

  • introduced 0, fixed 2.1.16 (semver)

Fixed versions

2.1.16

Fix

github.com/argoproj/argo-cd/v2

Go · All systems

Affected

  • introduced 2.2.0, fixed 2.2.10 (semver)

Fixed versions

2.2.10

Fix

github.com/argoproj/argo-cd/v2

Go · All systems

Affected

  • introduced 2.3.0, fixed 2.3.5 (semver)

Fixed versions

2.3.5

Fix

github.com/argoproj/argo-cd/v2

Go · All systems

Affected

  • introduced 2.4.0, fixed 2.4.1 (semver)

Fixed versions

2.4.1

Fix

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences