Advisory

GHSA-hvm9-wc8j-mgrc

Also known as: None

Summary

TShock Security Escalation Exploit

Details

Impact
An issue with the way OTAPI manages client connections results in stale UUIDs remaining on RemoteClient instances after a player disconnects.

Because of this, if the following conditions are met a player may assume the login state of a previously connected player:

  1. The server has UUID login enabled
  2. An authenticated player disconnects
  3. A subsequent player connects with a modified client that does not send the ClientUUID#68 packet during connection
  4. The server assigns the same RemoteClient object that belonged to the originally authenticated player to the newly connected player

Patches
TShock 5.2.1 hotfixes this issue. A more robust fix will be made to OTAPI itself.

Workarounds
Implement a RemoteClient reset event handler in a plugin like so:

public override void Initialize()
{
        On.Terraria.RemoteClient.Reset += RemoteClient_Reset;
}

private static void RemoteClient_Reset(On.Terraria.RemoteClient.orig_Reset orig, RemoteClient client)
{
	client.ClientUUID = null;
        orig(client);
}

Severity

High Basis: The source's own band: HIGH

Dates

Published
2024-12-18 18:19 UTC
Modified
2024-12-18 18:46 UTC

Affected packages and fixes

TShock

NuGet · All systems

Affected

  • introduced 4.3.21, fixed 5.2.1 (ecosystem)

Fixed versions

5.2.1

Fix

The export has no generic command for this ecosystem.

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences